feat: add Ubuntu/Debian native one-click deployment#82
Merged
iancaoo merged 1 commit intoJul 23, 2026
Merged
Conversation
wangjk9527
force-pushed
the
feat/native-one-click-deployment
branch
from
July 23, 2026 05:22
f415ebe to
0255b95
Compare
wangjk9527
force-pushed
the
feat/native-one-click-deployment
branch
4 times, most recently
from
July 23, 2026 08:32
7708e5f to
ca1617d
Compare
iancaoo
requested changes
Jul 23, 2026
iancaoo
left a comment
iancaoo
left a comment
Contributor
There was a problem hiding this comment.
几处功能性改动建议，请确认后再 merge。
selectPortWithHint（cli.mjs）print包装的 if/else 两分支都是print(message)，是无效分支；ask校验失败后无重试上限地递归options.ask(prompt)，持续输入非法值会无限循环。- CLI 的
verifyPorts调用verifySelectedPorts(services)时未传managedPorts，重新部署且端口被旧进程短暂占住时会误报「already in use」。 startManagedStack首次创建storage/logs/datafoundry.log时open(path, "a")未指定mode: 0o600，受进程 umask 影响可能为 0644，导致运行日志对其他用户可读（日志同样含 redact 过的敏感内容）。
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
iancaoo
dismissed
their stale review
July 23, 2026 11:39
duplicate submission of the same review (network retry); keeping the first copy
Collaborator
Author
|
针对 @iancaoo 的 3 条功能性意见，均已核实并处理：
|
提供 deploy.sh 原生部署链路（configure/install/build/start/stop/doctor/tui）， 含端口选择、托管进程状态、密钥脱敏与健康检查；并按评审收紧端口菜单重试、 verifyPorts managedPorts 透传，以及 runtime log 的 0o600 创建权限。
wangjk9527
force-pushed
the
feat/native-one-click-deployment
branch
from
July 23, 2026 11:45
ca1617d to
bda6ef6
Compare
iancaoo
approved these changes
Jul 23, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./deploy.sh原生一键部署入口，覆盖 deploy / start / stop / status / logs / doctor 等生命周期命令--reconfigure、后台运行等说明npm run test:deploy），覆盖配置、端口、健康检查与进程生命周期Test plan
npm run test:deploy本地通过./deploy.sh（或./deploy.sh deploy）完成配置、依赖安装与启动./deploy.sh status/logs/doctor输出正常./deploy.sh stop后服务停止，再./deploy.sh start可恢复.env时再次 deploy 会跳过交互；--reconfigure可重新配置