Repository navigation
Accept arrow 60 Metadata in the JSON field metadata test helper - #141
Merged
adriangb merged 1 commit intoSep 29, 2026
Merged
Conversation
arrow 60 returns field metadata as `&Metadata` rather than `&HashMap<String, String>` (apache/arrow-rs#10075), so `assert_json_field_metadata` no longer compiled against DataFusion `main`. Take any iterator of key/value pairs, which both types provide, so the tests build on arrow 59 and 60.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 93.05% 92.78% -0.28%
==========================================
Files 18 18
Lines 1815 1815
Branches 1815 1815
==========================================
- Hits 1689 1684 -5
Misses 70 70
- Partials 56 61 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arrow 60 returns field metadata as
&Metadatarather than&HashMap<String, String>(apache/arrow-rs#10075). DataFusionmainis now on arrow 60 (apache/datafusion#25335), and against it theassert_json_field_metadatatest helper no longer compiles.The helper now takes any iterator of key/value pairs, which both
&HashMapand&Metadataprovide, so the tests build on arrow 59 and 60. There's no library change:json_field_metadata()still returns aHashMap, andField::with_metadataaccepts it on arrow 60 throughInto<Metadata>.Tested with
cargo clippy --all-targets -- -D warningsandcargo test, both against the current DataFusion 55 release (arrow 59) and withdatafusionpatched to DataFusionmain(arrow 60).