Repository navigation
feat: display query-wide metric totals in plan dumps - #904
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answering "how much CPU did this whole query burn?" or "how many rows did all its operators produce?" from a plan dump currently means reading every node of every stage and adding up its metrics by hand, and each metric has to be combined its own way (summed, max'd, etc.).
This adds a totals view to
display_plan_dump(dfd plan -t): instead of rendering the plan, it adds up the metrics reported by every node of the query by name, using each metric's ownaggregate. The metrics derived for displaying stages, like a stage'selapsed_compute, are left out, as they're computed from the nodes' own and would count them twice.The existing filters compose with it:
--stage Nonly adds up the nodes of that stage, and-monly shows the totals of the matching metrics. Totals are always shown aggregated across tasks, since task ids of different stages are unrelated.