Skip to content

refactor: replace the coordinator-to-worker dialer closure with a Dialer struct - #882

Draft
gabotechs wants to merge 1 commit into
gabotechs/task-reports-on-dropfrom
gabotechs/coordinator-to-worker-dialer
Draft

gabotechs wants to merge 1 commit into
gabotechs/task-reports-on-dropfrom
gabotechs/coordinator-to-worker-dialer

Conversation

@gabotechs

@gabotechs gabotechs commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Just a no-op refactor for introducing a Dialer struct in place of the old new_coordinator_to_worker_dialer callback. This structure will make it easier to extend in the future.

@gabotechs
gabotechs added this pull request to stack #883 November 12, 2026 13:20
@gabotechs
gabotechs force-pushed the gabotechs/coordinator-to-worker-dialer branch from f22c65f to ecf46b6 Compare November 12, 2026 13:29
…ler struct

The dialer built in init_bidirectional_stream was a closure borrowing the
stage coordinator, wrapped by new_coordinator_to_worker_dialer. It is now
a Dialer struct that owns everything it needs to dial a worker, and keeps
the coordinator->worker sender of the last dial attempt. Owning its state
lets the dialer outlive the stage coordinator borrow, so routing can later
move into a spawned task.
@gabotechs
gabotechs force-pushed the gabotechs/coordinator-to-worker-dialer branch from ecf46b6 to 046f171 Compare November 19, 2026 10:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant