Skip to content

refactor: name the adaptive network boundary builder - #872

Merged
gabotechs merged 1 commit into
datafusion-contrib:mainfrom
joybestourous:joy/codex/dynamic-plan-builder
Nov 10, 2026
Merged

gabotechs merged 1 commit into
datafusion-contrib:mainfrom
joybestourous:joy/codex/dynamic-plan-builder

Conversation

@joybestourous

Copy link
Copy Markdown
Contributor

AQE stage preparation currently lives in a large async closure, which makes subsequent startup changes harder to review.

Move that callback into DynamicPlanBuilder, implementing the existing NetworkBoundaryBuilder trait. Task setup still joins all destinations before sampling kickoff; coalesce behavior, task counts, dynamic filters, statistics and metrics are unchanged. This is a preliminary refactor for #852.

Validation: 343 library tests passed, one ignored; formatting passed. The moved callback body was checked for equivalence after accounting for borrowed fields and the removed closure wrappers.

Move the existing AQE boundary callback into an implementation of
NetworkBoundaryBuilder without changing setup or sampling order.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-6 <noreply@localhost>

@gabotechs gabotechs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice! thanks @joybestourous

@gabotechs
gabotechs merged commit 33a15eb into datafusion-contrib:main Nov 10, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants