Skip to content

Native trim functions: support column-dependent trim sets #216

Description

@liuyongvs

Rechecked on 2026-09-20 against canonical main 89da01cdad7342c4d825e36eaf4e8dc73bc7af9f, released Apache Flink 2.2.1, JDK 17, default compatibility settings. Each expression was run against independent stock-Flink and StreamFusion-enabled streaming environments with bounded runtime DataStream input (parallelism 1), so source values cannot be folded away. Results and resolved result types agree through Flink fallback; this is a native support gap, not a demonstrated wrong-result bug.

BTRIM/LTRIM/RTRIM have native coverage only when the trim-set argument satisfies the literal gate. Adapted StringFunctionsITCase / ScalarFunctionsTest SQL confirms safe fallback for column-dependent sets.

Runtime s STRING='aabaXYZbaa', chars STRING='ab':

SELECT BTRIM(s, chars) FROM src; -- 'XYZ'

The verified minimal case returns STRING through Calc: BTRIM requires a literal trim set, with zero native substitutions. LTRIM/RTRIM upstream SQL also records the corresponding literal-set gates, including runtime NULL trim sets. Additional minimal probes on the same row return LTRIM(s,chars) = 'XYZbaa' and RTRIM(s,chars) = 'aabaXYZ', both through their respective literal-set gates.

Preserve Flink's set-of-characters semantics and actual argument order for each function. Test dynamic sets varying per row, NULL/empty sets and values, all-trimmed results, supplementary characters, slices and multiple batches. Existing literal-set native paths should remain controls.

Suggested priority: P2, common runtime STRING transformation.

Acceptance: add runtime-source SQL parity tests that assert native Calc execution as well as values and resolved types; include NULLs and boundary/error cases; retain safe fallback for unverified forms and update docs/operators/calc-filter.md with the admitted scope.

Latest-main validation: rebuilt the debug native library from this commit and ran 562 targeted runtime SQL cases covering these support gaps and adjacent controls. This issue group contains 8 successful comparisons that still record explicit fallback. Host-rejected/both-error cases are excluded from that count. This validates released Flink 2.2.1; it does not claim execution of the Flink 1.18 profile. No implementation is included.

Related: PR #44 documented narrower admitted overloads and the remaining fallback; this ticket tracks the unimplemented forms.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions