Skip to content

Fix(popup): condition check for popup display #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnaudfnr merged 2 commits into from
Apr 19, 2026
Merged

Fix(popup): condition check for popup display #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a00e7
Fix(popup): condition check for popup display
arnaudfnr Apr 19, 2026
40659eb
Improve console warns
arnaudfnr Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions coordo-ts/src/layers/popup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ export function makeSetLayerPopup({ map }: { map: MapLibreMap }) {
}

const onTrigger = async (ev: MapLayerMouseEvent | MapLayerTouchEvent) => {
const geometry = ev.features?.[0]?.geometry;
const lngLat = ev.lngLat;
const eventProps = ev.features?.[0]?.properties;
const id = ev.features?.[0]?.id;
if (geometry && id && eventProps) {
if (lngLat && Number(id) >= 0 && eventProps) {
/** @todo Remove "any" casting */
const popup = new Popup(popupConfig).setLngLat(ev.lngLat);

Expand All @@ -124,6 +124,14 @@ export function makeSetLayerPopup({ map }: { map: MapLibreMap }) {
}

popup.addTo(map);
} else if (!lngLat) {
console.warn("Missing property lngLat on event : ", ev);
} else if (!ev.features) {
console.warn("Event features not found");
} else if (!(Number(id) >= 0)) {
console.warn("event feature id is invalid: ", id);
} else if (!eventProps) {
console.warn("Event feature properties not found", eventProps);
}
};

Expand Down
Loading