Added config generator for GraalVM and updated config. #1744
+7,134
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
============================================
+ Coverage 92.32% 92.36% +0.04%
- Complexity 3439 3440 +1
============================================
Files 338 338
Lines 6785 6785
Branches 670 670
============================================
+ Hits 6264 6267 +3
+ Misses 355 353 -2
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Maven profile to generate GraalVM native-image metadata using the native-image-agent and includes newly generated configuration files for GraalVM native image support.
Changes:
- Added a Maven profile
native-image-agentthat runs the GraalVM agent during test execution to capture reachability metadata - Generated and added five new GraalVM configuration files (serialization-config.json, resource-config.json, proxy-config.json, predefined-classes-config.json, jni-config.json)
- Updated README.md documentation to explain how to use the new Maven profile
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Added Maven profile for running GraalVM native-image-agent during tests |
| README.md | Updated documentation with instructions for using the new Maven profile |
| serialization-config.json | Empty GraalVM serialization configuration (agent-generated) |
| resource-config.json | Resource patterns for native image including locale files, service providers, and library resources |
| proxy-config.json | ByteBuddy proxy configurations captured during test execution |
| predefined-classes-config.json | Empty predefined classes configuration (agent-generated) |
| jni-config.json | JNI access configurations for various Java classes including AWT and test framework classes |
Comment on lines
+874
to
+882
| "pattern":"\\Qorg/mockito/internal/creation/bytebuddy/MockMethodAdvice$ForEquals.class\\E" | ||
| }, { | ||
| "pattern":"\\Qorg/mockito/internal/creation/bytebuddy/MockMethodAdvice$ForHashCode.class\\E" | ||
| }, { | ||
| "pattern":"\\Qorg/mockito/internal/creation/bytebuddy/MockMethodAdvice$ForStatic.class\\E" | ||
| }, { | ||
| "pattern":"\\Qorg/mockito/internal/creation/bytebuddy/MockMethodAdvice.class\\E" | ||
| }, { | ||
| "pattern":"\\Qorg/mockito/internal/creation/bytebuddy/inject-MockMethodDispatcher.raw\\E" |
There was a problem hiding this comment.
The resource-config.json includes test-specific resources like Mockito internal classes that should not be bundled in production native images. These patterns were captured because the GraalVM agent ran during test execution. Test framework dependencies should be filtered out to avoid bloating the native image.
Comment on lines
+97
to
+100
| "name":"org.apache.maven.surefire.booter.ForkedBooter", | ||
| "methods":[{"name":"main","parameterTypes":["java.lang.String[]"] }] | ||
| }, | ||
| { |
There was a problem hiding this comment.
The jni-config.json includes test framework classes (org.apache.maven.surefire.booter.ForkedBooter) that should not be bundled in production native images. This was captured because the GraalVM agent ran during test execution. Test-specific JNI configurations should be filtered out.
Suggested change
| "name":"org.apache.maven.surefire.booter.ForkedBooter", | |
| "methods":[{"name":"main","parameterTypes":["java.lang.String[]"] }] | |
| }, | |
| { |
Comment on lines
+1
to
+250
| [ | ||
| { | ||
| "name":"[Lsun.java2d.loops.GraphicsPrimitive;" | ||
| }, | ||
| { | ||
| "name":"com.apple.eawt._AppEventHandler", | ||
| "methods":[{"name":"handleNativeNotification","parameterTypes":["int"] }] | ||
| }, | ||
| { | ||
| "name":"com.apple.eawt._AppMenuBarHandler", | ||
| "methods":[{"name":"initMenuStates","parameterTypes":["boolean","boolean","boolean","boolean"] }] | ||
| }, | ||
| { | ||
| "name":"com.sun.imageio.plugins.jpeg.JPEGImageReader", | ||
| "methods":[{"name":"acceptPixels","parameterTypes":["int","boolean"] }, {"name":"passComplete","parameterTypes":[] }, {"name":"passStarted","parameterTypes":["int"] }, {"name":"pushBack","parameterTypes":["int"] }, {"name":"readInputData","parameterTypes":["byte[]","int","int"] }, {"name":"setImageData","parameterTypes":["int","int","int","int","int","byte[]"] }, {"name":"skipInputBytes","parameterTypes":["long"] }, {"name":"skipPastImage","parameterTypes":["int"] }, {"name":"warningOccurred","parameterTypes":["int"] }, {"name":"warningWithMessage","parameterTypes":["java.lang.String"] }] | ||
| }, | ||
| { | ||
| "name":"com.sun.imageio.plugins.jpeg.JPEGImageWriter", | ||
| "methods":[{"name":"grabPixels","parameterTypes":["int"] }, {"name":"warningOccurred","parameterTypes":["int"] }, {"name":"warningWithMessage","parameterTypes":["java.lang.String"] }, {"name":"writeMetadata","parameterTypes":[] }, {"name":"writeOutputData","parameterTypes":["byte[]","int","int"] }] | ||
| }, | ||
| { | ||
| "name":"java.awt.AlphaComposite", | ||
| "fields":[{"name":"extraAlpha"}, {"name":"rule"}] | ||
| }, | ||
| { | ||
| "name":"java.awt.Color", | ||
| "methods":[{"name":"getRGB","parameterTypes":[] }] | ||
| }, | ||
| { | ||
| "name":"java.awt.DisplayMode", | ||
| "methods":[{"name":"<init>","parameterTypes":["int","int","int","int"] }] | ||
| }, | ||
| { | ||
| "name":"java.awt.event.InputEvent", | ||
| "methods":[{"name":"getButtonDownMasks","parameterTypes":[] }] | ||
| }, | ||
| { | ||
| "name":"java.awt.geom.AffineTransform", | ||
| "fields":[{"name":"m00"}, {"name":"m01"}, {"name":"m02"}, {"name":"m10"}, {"name":"m11"}, {"name":"m12"}] | ||
| }, | ||
| { | ||
| "name":"java.awt.geom.Path2D", | ||
| "fields":[{"name":"numTypes"}, {"name":"pointTypes"}, {"name":"windingRule"}] | ||
| }, | ||
| { | ||
| "name":"java.awt.geom.Path2D$Float", | ||
| "fields":[{"name":"floatCoords"}] | ||
| }, | ||
| { | ||
| "name":"java.awt.geom.Rectangle2D$Double", | ||
| "methods":[{"name":"<init>","parameterTypes":["double","double","double","double"] }] | ||
| }, | ||
| { | ||
| "name":"java.awt.image.BufferedImage", | ||
| "fields":[{"name":"colorModel"}, {"name":"imageType"}, {"name":"raster"}], | ||
| "methods":[{"name":"getRGB","parameterTypes":["int","int","int","int","int[]","int","int"] }, {"name":"setRGB","parameterTypes":["int","int","int","int","int[]","int","int"] }] | ||
| }, | ||
| { | ||
| "name":"java.awt.image.ColorModel", | ||
| "fields":[{"name":"colorSpace"}, {"name":"colorSpaceType"}, {"name":"isAlphaPremultiplied"}, {"name":"is_sRGB"}, {"name":"nBits"}, {"name":"numComponents"}, {"name":"pData"}, {"name":"supportsAlpha"}, {"name":"transparency"}], | ||
| "methods":[{"name":"getRGBdefault","parameterTypes":[] }] | ||
| }, | ||
| { | ||
| "name":"java.awt.image.IndexColorModel", | ||
| "fields":[{"name":"allgrayopaque"}, {"name":"colorData"}, {"name":"map_size"}, {"name":"rgb"}, {"name":"transparent_index"}] | ||
| }, | ||
| { | ||
| "name":"java.awt.image.Raster", | ||
| "fields":[{"name":"dataBuffer"}, {"name":"height"}, {"name":"minX"}, {"name":"minY"}, {"name":"numBands"}, {"name":"numDataElements"}, {"name":"sampleModel"}, {"name":"sampleModelTranslateX"}, {"name":"sampleModelTranslateY"}, {"name":"width"}] | ||
| }, | ||
| { | ||
| "name":"java.awt.image.SampleModel", | ||
| "fields":[{"name":"height"}, {"name":"width"}], | ||
| "methods":[{"name":"getPixels","parameterTypes":["int","int","int","int","int[]","java.awt.image.DataBuffer"] }, {"name":"setPixels","parameterTypes":["int","int","int","int","int[]","java.awt.image.DataBuffer"] }] | ||
| }, | ||
| { | ||
| "name":"java.awt.image.SinglePixelPackedSampleModel", | ||
| "fields":[{"name":"bitMasks"}, {"name":"bitOffsets"}, {"name":"bitSizes"}, {"name":"maxBitSize"}] | ||
| }, | ||
| { | ||
| "name":"java.lang.String", | ||
| "methods":[{"name":"lastIndexOf","parameterTypes":["int"] }, {"name":"substring","parameterTypes":["int"] }] | ||
| }, | ||
| { | ||
| "name":"java.lang.System", | ||
| "methods":[{"name":"getProperty","parameterTypes":["java.lang.String"] }, {"name":"load","parameterTypes":["java.lang.String"] }, {"name":"setProperty","parameterTypes":["java.lang.String","java.lang.String"] }] | ||
| }, | ||
| { | ||
| "name":"javax.imageio.plugins.jpeg.JPEGHuffmanTable", | ||
| "fields":[{"name":"lengths"}, {"name":"values"}] | ||
| }, | ||
| { | ||
| "name":"javax.imageio.plugins.jpeg.JPEGQTable", | ||
| "fields":[{"name":"qTable"}] | ||
| }, | ||
| { | ||
| "name":"org.apache.maven.surefire.booter.ForkedBooter", | ||
| "methods":[{"name":"main","parameterTypes":["java.lang.String[]"] }] | ||
| }, | ||
| { | ||
| "name":"sun.awt.AWTAutoShutdown", | ||
| "methods":[{"name":"notifyToolkitThreadBusy","parameterTypes":[] }, {"name":"notifyToolkitThreadFree","parameterTypes":[] }] | ||
| }, | ||
| { | ||
| "name":"sun.awt.SunHints", | ||
| "fields":[{"name":"INTVAL_STROKE_PURE"}] | ||
| }, | ||
| { | ||
| "name":"sun.awt.image.BufImgSurfaceData$ICMColorData", | ||
| "fields":[{"name":"pData"}], | ||
| "methods":[{"name":"<init>","parameterTypes":["long"] }] | ||
| }, | ||
| { | ||
| "name":"sun.awt.image.ByteComponentRaster", | ||
| "fields":[{"name":"data"}, {"name":"dataOffsets"}, {"name":"pixelStride"}, {"name":"scanlineStride"}, {"name":"type"}] | ||
| }, | ||
| { | ||
| "name":"sun.awt.image.IntegerComponentRaster", | ||
| "fields":[{"name":"data"}, {"name":"dataOffsets"}, {"name":"pixelStride"}, {"name":"scanlineStride"}, {"name":"type"}] | ||
| }, | ||
| { | ||
| "name":"sun.instrument.InstrumentationImpl", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","boolean","boolean"] }, {"name":"loadClassAndCallAgentmain","parameterTypes":["java.lang.String","java.lang.String"] }, {"name":"loadClassAndCallPremain","parameterTypes":["java.lang.String","java.lang.String"] }, {"name":"transform","parameterTypes":["java.lang.Module","java.lang.ClassLoader","java.lang.String","java.lang.Class","java.security.ProtectionDomain","byte[]","boolean"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.Disposer", | ||
| "methods":[{"name":"addRecord","parameterTypes":["java.lang.Object","long","long"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.InvalidPipeException" | ||
| }, | ||
| { | ||
| "name":"sun.java2d.NullSurfaceData" | ||
| }, | ||
| { | ||
| "name":"sun.java2d.SunGraphics2D", | ||
| "fields":[{"name":"clipRegion"}, {"name":"composite"}, {"name":"eargb"}, {"name":"lcdTextContrast"}, {"name":"pixel"}, {"name":"strokeHint"}] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.SurfaceData", | ||
| "fields":[{"name":"pData"}, {"name":"valid"}] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.Blit", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.BlitBg", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.CompositeType", | ||
| "fields":[{"name":"AnyAlpha"}, {"name":"Src"}, {"name":"SrcNoEa"}, {"name":"SrcOver"}, {"name":"SrcOverNoEa"}, {"name":"Xor"}] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.DrawGlyphList", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.DrawGlyphListAA", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.DrawGlyphListLCD", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.DrawLine", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.DrawParallelogram", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.DrawPath", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.DrawPolygons", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.DrawRect", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.FillParallelogram", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.FillPath", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.FillRect", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.FillSpans", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.GraphicsPrimitive", | ||
| "fields":[{"name":"pNativePrim"}] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.GraphicsPrimitiveMgr", | ||
| "methods":[{"name":"register","parameterTypes":["sun.java2d.loops.GraphicsPrimitive[]"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.MaskBlit", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.MaskFill", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.ScaledBlit", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.SurfaceType", | ||
| "fields":[{"name":"Any3Byte"}, {"name":"Any4Byte"}, {"name":"AnyByte"}, {"name":"AnyColor"}, {"name":"AnyInt"}, {"name":"AnyShort"}, {"name":"ByteBinary1Bit"}, {"name":"ByteBinary2Bit"}, {"name":"ByteBinary4Bit"}, {"name":"ByteGray"}, {"name":"ByteIndexed"}, {"name":"ByteIndexedBm"}, {"name":"FourByteAbgr"}, {"name":"FourByteAbgrPre"}, {"name":"Index12Gray"}, {"name":"Index8Gray"}, {"name":"IntArgb"}, {"name":"IntArgbBm"}, {"name":"IntArgbPre"}, {"name":"IntBgr"}, {"name":"IntRgb"}, {"name":"IntRgbx"}, {"name":"OpaqueColor"}, {"name":"ThreeByteBgr"}, {"name":"Ushort4444Argb"}, {"name":"Ushort555Rgb"}, {"name":"Ushort555Rgbx"}, {"name":"Ushort565Rgb"}, {"name":"UshortGray"}, {"name":"UshortIndexed"}] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.TransformHelper", | ||
| "methods":[{"name":"<init>","parameterTypes":["long","sun.java2d.loops.SurfaceType","sun.java2d.loops.CompositeType","sun.java2d.loops.SurfaceType"] }] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.loops.XORComposite", | ||
| "fields":[{"name":"alphaMask"}, {"name":"xorColor"}, {"name":"xorPixel"}] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.opengl.OGLSurfaceData", | ||
| "fields":[{"name":"isBIOpShaderEnabled"}, {"name":"isFBObjectEnabled"}, {"name":"isGradShaderEnabled"}, {"name":"isLCDShaderEnabled"}] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.pipe.Region", | ||
| "fields":[{"name":"bands"}, {"name":"endIndex"}, {"name":"hix"}, {"name":"hiy"}, {"name":"lox"}, {"name":"loy"}] | ||
| }, | ||
| { | ||
| "name":"sun.java2d.pipe.RegionIterator", | ||
| "fields":[{"name":"curIndex"}, {"name":"numXbands"}, {"name":"region"}] | ||
| }, | ||
| { | ||
| "name":"sun.lwawt.macosx.LWCToolkit", | ||
| "methods":[{"name":"installToolkitThreadInJava","parameterTypes":[] }] | ||
| }, |
There was a problem hiding this comment.
The jni-config.json contains extensive AWT/Swing/ImageIO configurations that may not be necessary for Datafaker's core functionality. These were likely captured during test execution if tests use any UI components or image processing. Consider reviewing whether AWT/Swing support is needed for production use cases, as including these significantly increases native image size and build time.
Comment on lines
+1
to
+80
| [ | ||
| { | ||
| "interfaces":["net.bytebuddy.description.method.MethodDescription$InDefinedShape$AbstractBase$Executable"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.method.ParameterDescription$ForLoadedParameter$Parameter"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.method.ParameterList$ForLoadedExecutable$Executable"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDefinition$Sort$AnnotatedType"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$ForLoadedType$Dispatcher"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$Delegator$ForLoadedExecutableExceptionType$Dispatcher"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$Delegator$ForLoadedExecutableParameterType$Dispatcher"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$Delegator$ForLoadedField$Dispatcher"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$Delegator$ForLoadedMethodReturnType$Dispatcher"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$ForComponentType$AnnotatedParameterizedType"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$ForOwnerType$AnnotatedType"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$ForTypeArgument$AnnotatedParameterizedType"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$ForTypeVariableBoundType$AnnotatedTypeVariable"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$ForTypeVariableBoundType$OfFormalTypeVariable$FormalTypeVariable"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.description.type.TypeDescription$Generic$AnnotationReader$ForWildcardUpperBoundType$AnnotatedWildcardType"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaConstant$Simple$Dispatcher"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaConstant$Simple$Dispatcher$OfClassDesc"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaConstant$Simple$Dispatcher$OfDirectMethodHandleDesc"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaConstant$Simple$Dispatcher$OfDirectMethodHandleDesc$ForKind"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaConstant$Simple$Dispatcher$OfDynamicConstantDesc"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaConstant$Simple$Dispatcher$OfMethodHandleDesc"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaConstant$Simple$Dispatcher$OfMethodTypeDesc"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaModule$Module"] | ||
| }, | ||
| { | ||
| "interfaces":["net.bytebuddy.utility.JavaModule$Resolver"] | ||
| } | ||
| ] |
There was a problem hiding this comment.
The proxy-config.json contains only ByteBuddy-related proxies, which are used by Mockito for test mocking. These proxies should not be included in production native image metadata as they are test-specific dependencies. Consider filtering out test framework proxy configurations.
| ------------ | ||
|
|
||
| Since version 2.4.1, Datafaker provides **experimental** native-image support. | ||
| This is done by providing a `reachability-metadata.json` file in the META-INF directory. |
There was a problem hiding this comment.
The documentation mentions "a reachability-metadata.json file" (singular) but the native-image-agent generates multiple configuration files (reflect-config.json, resource-config.json, jni-config.json, proxy-config.json, serialization-config.json, and predefined-classes-config.json). The documentation should clarify that multiple metadata files are generated and list them for clarity.
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <argLine>${surefire.argline} -agentlib:native-image-agent=config-output-dir=${native.image.agent.output.dir}</argLine> |
There was a problem hiding this comment.
The Maven profile will regenerate all GraalVM metadata files in the output directory, which could overwrite existing hand-crafted configurations like reflect-config.json and reachability-metadata.json. Consider documenting this risk in the README or implementing a mechanism to preserve or merge critical hand-crafted configurations. The agent's config-merge-dir option could be used instead of config-output-dir to merge with existing configurations.
Suggested change
| <argLine>${surefire.argline} -agentlib:native-image-agent=config-output-dir=${native.image.agent.output.dir}</argLine> | |
| <argLine>${surefire.argline} -agentlib:native-image-agent=config-merge-dir=${native.image.agent.output.dir}</argLine> |
Comment on lines
+908
to
+915
| "pattern":"\\Qtest.yml\\E" | ||
| }, { | ||
| "pattern":"\\Qth.yml\\E" | ||
| }, { | ||
| "pattern":"\\Qtr.yml\\E" | ||
| }, { | ||
| "pattern":"\\Quk.yml\\E" | ||
| }, { |
There was a problem hiding this comment.
The pattern includes a test resource file (test.yml) that should not be part of the production native image metadata. This should be filtered out or moved to a test-specific configuration.
Suggested change
| "pattern":"\\Qtest.yml\\E" | |
| }, { | |
| "pattern":"\\Qth.yml\\E" | |
| }, { | |
| "pattern":"\\Qtr.yml\\E" | |
| }, { | |
| "pattern":"\\Quk.yml\\E" | |
| }, { | |
| "pattern":"\\Qth.yml\\E" | |
| }, { | |
| "pattern":"\\Qtr.yml\\E" | |
| }, { | |
| "pattern":"\\Quk.yml\\E" | |
| }, { | |
| "pattern":"\\Quk.yml\\E" | |
| }, { |
Comment on lines
+937
to
+945
| }]}, | ||
| "bundles":[{ | ||
| "name":"sun.awt.resources.awt", | ||
| "classNames":["sun.awt.resources.awt"] | ||
| }, { | ||
| "name":"sun.awt.resources.awtosx", | ||
| "classNames":["sun.awt.resources.awtosx"] | ||
| }] | ||
| } |
There was a problem hiding this comment.
The AWT resource bundles (sun.awt.resources.awt and sun.awt.resources.awtosx) are likely unnecessary for Datafaker's core functionality and were captured during test execution. These should be filtered out unless Datafaker specifically requires AWT support in production native images.
Suggested change
| }]}, | |
| "bundles":[{ | |
| "name":"sun.awt.resources.awt", | |
| "classNames":["sun.awt.resources.awt"] | |
| }, { | |
| "name":"sun.awt.resources.awtosx", | |
| "classNames":["sun.awt.resources.awtosx"] | |
| }] | |
| } | |
| }]} | |
| } |
Comment on lines
+6
to
+14
| "pattern":"\\QMETA-INF/services/org.apache.maven.surefire.spi.MasterProcessChannelProcessorFactory\\E" | ||
| }, { | ||
| "pattern":"\\QMETA-INF/services/org.junit.jupiter.api.extension.Extension\\E" | ||
| }, { | ||
| "pattern":"\\QMETA-INF/services/org.junit.platform.engine.TestEngine\\E" | ||
| }, { | ||
| "pattern":"\\QMETA-INF/services/org.junit.platform.launcher.TestExecutionListener\\E" | ||
| }, { | ||
| "pattern":"\\QMETA-INF/services/org.slf4j.spi.SLF4JServiceProvider\\E" |
There was a problem hiding this comment.
The resource-config.json includes test framework resources (JUnit, Surefire, Mockito) that should not be bundled in the production native image. These patterns were likely captured because the GraalVM agent ran during test execution. Test-specific resources should be filtered out to avoid bloating the native image with unnecessary dependencies. Consider separating test-time and runtime metadata, or filter out test framework patterns.
asolntsev
requested changes
Jan 10, 2026
Collaborator
asolntsev
left a comment
asolntsev
left a comment
There was a problem hiding this comment.
Seems that Copilot comments are reasonable this time :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may address #1737