Skip to content

Automated Integration Test Goldens Update from CI#6337

Closed
datacommons-robot-author wants to merge 2 commits into
masterfrom
nl-golden-update-d5c03584-1639-4e00-a474-c648c4c3251f
Closed

Automated Integration Test Goldens Update from CI#6337
datacommons-robot-author wants to merge 2 commits into
masterfrom
nl-golden-update-d5c03584-1639-4e00-a474-c648c4c3251f

Conversation

@datacommons-robot-author
Copy link
Copy Markdown
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@datacommons-robot-author datacommons-robot-author requested review from a team and beets and removed request for a team June 4, 2026 18:19
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains an automated update to the integration test golden files. These changes ensure that the test expectations remain synchronized with the latest output from the detection API.

Highlights

  • Integration Test Goldens Update: Updated the chart configuration for the stateswithhighestphds test case to include a new classification definition.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration test data configuration in chart_config.json by adding a new classification entry with a quantity filter of type 3 and a minimum value threshold. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copy link
Copy Markdown
Contributor

@gmechali gmechali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a benign change. approving

@gmechali
Copy link
Copy Markdown
Contributor

gmechali commented Jun 4, 2026

Thsi change wnet in by mistake in Xiao's pr: 83fdf92#diff-ba067050b3ae5b6d86dcf0a60f9992c3cefb2864bbf5078a76c12f362e0c0d8e

Same result, but closing this PR

@gmechali gmechali closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants