Update memory and add cpu requests to deployment configs#1920
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the mixer Helm chart to support dynamic configuration of ESP container resources (CPU and memory) globally or per service group, standardizes memory units to "Gi", and adds CPU requests across several service groups. Feedback suggests simplifying the ESP resource assignment logic in deployment.yaml by removing redundant conditional checks, as $.Values.esp is already guaranteed to be defined.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| {{- $espResources := $group.espResources | default dict }} | ||
| {{- $espGlobalResources := dict }} | ||
| {{- if $.Values.esp }} | ||
| {{- $espGlobalResources = $.Values.esp.resources | default dict }} | ||
| {{- end }} | ||
| resources: | ||
| limits: | ||
| memory: "300M" | ||
| memory: {{ $espResources.memoryLimit | default $espGlobalResources.memoryLimit | default "300M" | quote }} | ||
| {{- if or $espResources.cpuLimit $espGlobalResources.cpuLimit }} | ||
| cpu: {{ $espResources.cpuLimit | default $espGlobalResources.cpuLimit | quote }} | ||
| {{- end }} | ||
| requests: | ||
| memory: "300M" | ||
| memory: {{ $espResources.memoryRequest | default $espGlobalResources.memoryRequest | default "300M" | quote }} | ||
| {{- if or $espResources.cpuRequest $espGlobalResources.cpuRequest }} | ||
| cpu: {{ $espResources.cpuRequest | default $espGlobalResources.cpuRequest | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
We can simplify the ESP resources assignment and ensure consistency with the memory units.
- Simplify template logic: Since
$.Values.espis guaranteed to be a map (as its nested fields like$.Values.esp.image.repositoryare accessed directly on line 352 without guards), we can safely access$.Values.esp.resourcesdirectly without the conditionalifblock and variable reassignment.
1 participant
No description provided.