Skip to content

Add ingestion_input_path to top level tf outputs #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clincoln8 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add ingestion_input_path to top level tf outputs #72

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db9e796
add ingestion_input_path to outputs
clincoln8 May 22, 2026
4cda63b
Merge branch 'main' into expose-input-path
clincoln8 May 22, 2026
222e723
Merge branch 'main' into expose-input-path
clincoln8 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions infra/dcp/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,9 @@ output "region" {
description = "The GCP region where resources are deployed"
value = var.region
}

output "ingestion_input_path" {
description = "Path within the bucket where raw files should be uploaded"
value = var.ingestion_input_path
}
Comment on lines +63 to +66
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with other outputs in this project and avoid providing misleading information when the ingestion feature is disabled, this output should be conditional on var.enable_ingestion. Additionally, the description should be updated to match the one used in the variable definition for consistency. Since this output relies on the ingestion_bucket_url from another stack, ensure this dependency is explicitly documented in the Terraform variable descriptions or comments to prevent confusion regarding its optionality, as per repository rules.

output "ingestion_input_path" {
  description = "Path within the bucket where raw files are uploaded"
  value       = var.enable_ingestion ? var.ingestion_input_path : null
}
References
  1. When an infrastructure component or workflow step has a mandatory dependency on another stack, ensure this requirement is explicitly documented in Terraform variable descriptions or comments to prevent confusion regarding its optionality.


Loading