fix: readiness legge columns/rules dal run record, inspect mostra verdict - #442
Merged
Conversation
…dict Problema: 2 check di review_readiness (clean_columns_naming, validation_rules_coverage) erano sempre null perché la validazione buttava via columns/rules e summary() non esponeva validation. - core/validation.py: build_validation_summary salva il blocco summary completo (stats+columns+rules) nel run record - domain/readiness.py: summary() espone layers.*.validation; review_readiness legge da summary con fallback su legacy - cli/inspect/summary_ops.py: inspect (default) mostra il verdict readiness con check — comando unico fatti+giudizio - cli/cmd_run.py: review_readiness usa cfg.base_dir/dataset.yml (config=None in auto-detect rompeva il run finale) Verificato: dipendenti-pubblici run 2010, readiness needs-review 7/8 (coverage 13% reale, non più null). 1235 test passano.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Fix del contratto rotto tra
summary(),review_readiness()e il run record: 2 check di readiness (clean_columns_naming,validation_rules_coverage) erano sempre null perché la validazione buttava viacolumns/rules. Inoltretoolkit inspect(default) ora mostra il verdict readiness — il comando unico fatti + giudizio.Cosa cambia
Impatto su contratti pubblici
validations.{layer}.summarynuovo blocco (stats+columns+rules).statsappiattito mantenuto per backward compat.Root cause
La validazione in memoria (PR #436) copiava nel run record solo
stats, buttando viacolumnserulesche la validazione produce.review_readinessli cercava inlayers.*.validation, masummary()non esponevavalidation. Risultato: 2 check su 8 semprenulle verdictreadycon check mai valutati.Cosa è stato fatto
core/validation.pybuild_validation_summarysalva bloccosummarycompleto (stats+columns+rules) nel run recorddomain/readiness.pysummary()esponelayers.*.validation;review_readinesslegge dasummarycon fallback legacycli/inspect/summary_ops.pyinspectdefault stampa verdict readiness + check (comando unico)cli/cmd_run.pyreview_readinessusacfg.base_dir/dataset.yml—config=Nonein auto-detect rompeva il run finaleVerifica
Prima: i 2 check erano
ok=null("colonne clean non disponibili"). Ora valutano davvero.Checklist PR
Note per chi revisiona
summary: readiness usa il fallback (check restano null finché non si riesegue). Comportamento atteso.validation_rules_coverageora è severo: un dataset con poche regole dichiarate passa dareadyaneeds-review. Verificare che i candidate esistenti siano coerenti.