feat: config auto-detect, run default, inspect unificato - #439
Merged
Conversation
- Nuovo core/discovery.py con resolve_config_path() centralizzata - load_config() accetta path=None (auto-detect da CWD, climbing, slug) - toolkit run diventa il default (preflight + support + raw->clean->mart) Subcomandi: preflight, raw, clean, mart - toolkit inspect diventa comando unico con flag di modo --schema|--preview|--profile|--runs|--resume|--diff - Vecchi subcomandi inspect deprecati (hidden, backward compat) - dataset_loader.py usa resolve_config_path() anziché risoluzione ad-hoc - mcp/path_safety.py: thin wrapper su resolve_config_path() - 1165 test passano, 0 falliti
style: ruff format dopo refactor inspect
Gabrymi93
force-pushed
the
feat/config-auto-detect
branch
from
July 30, 2026 17:50
1b6d3ea to
2342891
Compare
…i alla nuova CLI Aggiunti test contract per auto-detect config (CWD, slug, mancante). Docstring _execute_pipeline() con parametri documentati.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Centralizzata la risoluzione del path di
dataset.yml(prima sparsa in MCP, catalog, notebook_helpers, CLI). Unificatotoolkit run(default = pipeline completa) e semplificatotoolkit inspect(default + 2 subcomandi).--configdiventa opzionale con auto-detect CWD/slug.Cosa cambia
CLI finale
--configopzionale: se omesso cercadataset.ymlnella CWD; se è uno slug (es.terna-electricity-by-source) risolve indataset-incubator/{candidates,compose,support_datasets}/run all,run full,run init,inspect summary,inspect profile,inspect pathsrun_full()mantenuto come API Python deprecata (DeprecationWarning)Verifica
pytest -m corepassaruff check .passamypy toolkit/passa (2 errori preesistenti in read_excel.py e profile/raw.py, non toccati)Metriche (root-cause-change)
Tipo: contract alignment + cleanup reale
Problema reale: 4 implementazioni sparse della stessa logica (risoluzione path dataset.yml) + CLI con troppi subcomandi ridondanti
Contratto riusato/sostituito:
resolve_config_path()incore/discovery.pyassorbe MCP._resolve_dataset + notebook_helpers.find_config + CLI --config obbligatorioCodice rimosso o duplicazione eliminata:
mcp/path_safety.py: da ~140 a ~30 righe (delega a discovery.py)inspect/__init__.py: da 251 a 68 righe (subcomandi, non flag di modo)run all,run full,run init,inspect summary,inspect profile,inspect pathsRischio residuo:
inspect pathsnon ha equivalente direttoNote per chi revisiona
Il grosso del refactor è in:
core/discovery.py(nuovo): risoluzione config in 86 righecli/inspect/__init__.py: inspect con default + 2 subcomandi (config, runs)cli/cmd_run.py: run diventa default, subcomandi ridotti a 4mcp/path_safety.py: thin wrapper su discovery