Repository navigation
Rerun the Gemini auth-recovery e2e case on a live gateway timeout - #1612
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
lilly-luo
marked this pull request as ready for review
November 12, 2026 03:54
masonc08
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestGeminiAuthRecovery::test_recovers_when_initial_token_emptyflakes when the live Gemini model is slow. Its direct gateway call (_run_gemini_gateway_smoke) usesurlopen(timeout=30), and on a slow response that raises a bareTimeoutError: The read operation timed out. The e2e shards already rerun live timeouts once (#1245), but only failures matchingtimed out after [0-9]+s, so this case fails on the first attempt while the CLI launch tests next to it get their rerun.This change converts a socket timeout (bare, or wrapped in
URLErroron connect) intoAssertionError: Gemini gateway smoke for model=<m> timed out after 30s. That matches the existing--only-rerunpattern. HTTP errors and otherURLErrors still fail immediately. Tests only; no product code.Seen on both Gemini shards in https://github.com/databricks/unity-gateway/actions/runs/40733908631 (Oct 28) and again on Windows in run 43048607627 (Nov 11, after #1595).
Tests
ruff check/ruff format --checkclean ontests/test_e2e.py.--reruns 1 --only-rerun 'timed out after [0-9]+s'), withurlopenpatched to raise. A bareTimeoutErrorand aURLError(socket.timeout)each produceRERUN. A non-timeoutURLErrorpropagates unchanged.This pull request and its description were written by Isaac.