Bump jws to 4.0.1 (security: GHSA-869p-cjfg-cm3x)#1953
Open
rugpanov wants to merge 1 commit into
Open
Conversation
*Why* Dependabot's #1816 (jws 4.0.0 -> 4.0.1) could not merge: it was a lockfile-only bump that conflicted with main after recent merges. jws 4.0.1 fixes advisory GHSA-869p-cjfg-cm3x (createSign/createVerify signature-header handling). jws is a transitive dependency (via google-auth-library and gtoken, both requesting ^4.0.0), so it can't be bumped with `yarn up`; it needs a resolution override. *What* - Add `"jws": "^4.0.1"` to the root `resolutions` block (following the existing json5 / path-scurry pattern) to force the transitive dependency to the patched version. Regenerated yarn.lock now resolves jws@4.0.1 (and jwa@2.0.1). *Verification* - `yarn install --immutable` passes (the CI gate that #1816 failed). - Resolved versions verified to exist on public npm (jws@4.0.1, jwa@2.0.1). - Both dependents request `^4.0.0`, which permits 4.0.1 — no peer conflicts. Backward compatibility: transitive security patch only; no direct dependency, API, persisted state, or config change. Closes #1816. Co-authored-by: Isaac
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rugpanov
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
Contributor
Author
|
Integration tests: https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/28607412003 TLDR: no regressions — 25 passing / 7 failing, matching the current e2e baseline. Zero |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Replaces Dependabot's #1816, which couldn't merge (lockfile-only bump, conflicted with main after recent merges). jws 4.0.1 fixes advisory GHSA-869p-cjfg-cm3x —
createSign/createVerifynow require signature headers, mitigating a JWT signature-verification flaw.jwsis a transitive dependency (viagoogle-auth-libraryandgtoken, both requesting^4.0.0), so it can't be bumped withyarn up— it needs a resolution override.What
"jws": "^4.0.1"to the rootresolutionsblock (following the existingjson5/path-scurrypattern).yarn.lockresolvesjws@4.0.1(andjwa@2.0.1).Verification
yarn install --immutablepasses (the CI gate Bump jws from 4.0.0 to 4.0.1 #1816 failed on).jws@4.0.1,jwa@2.0.1).^4.0.0, which permits 4.0.1 — no peer conflicts.Backward compatibility: transitive security patch only; no direct dependency, API, persisted-state, or config change.
Closes #1816.
This pull request and its description were written by Isaac.