Bump markdown-it from 12.3.2 to 14.2.0#1951
Merged
Merged
Conversation
*Why* Dependabot's markdown-it 12->14 PR (#1946) could not merge: its lockfile pinned `linkify-it@5.0.2`, a version that does not exist on the public npm registry (latest is 5.0.1), so `yarn install --immutable` failed in CI with a 403 from the JFrog mirror (nothing to serve). This PR regenerates the lockfile against real, published versions and takes the markdown-it major upgrade deliberately. *What* - Bump `markdown-it` to `^14.2.0` in packages/databricks-vscode/package.json. - Regenerate yarn.lock; it resolves to real versions: markdown-it 14.2.0 with linkify-it 5.0.1, mdurl 2.0.0, punycode.js 2.3.1, uc.micro 2.1.0. - markdown-it is consumed only as the prebuilt UMD bundle (`dist/markdown-it.min.js`) loaded by the Unity Catalog detail webview (resources/webview-ui/uc-detail.js): `window.markdownit({html:false, linkify:true, typographer:false})` + `md.render(text)`. That constructor + render API is unchanged across v12->v14, and v14 still exposes the `window.markdownit` UMD global, so no call-site changes are needed. There is no TypeScript import of markdown-it and no `@types/markdown-it` dependency. *Verification* - `yarn install` regenerates cleanly; all resolved deps verified to exist on public npm (no phantom versions). - `yarn run build` passes; `package:copy-markdown-it` ships the v14 `markdown-it.min.js` (124 KB) into `out/`. - Webview usage reviewed against v14 API (constructor + render + linkify) — compatible. Backward compatibility: only the bundled markdown renderer version changes; the webview API usage is identical. No persisted state, config, or public API change. Co-authored-by: Isaac
rugpanov
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
Contributor
Author
|
Integration tests: https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/28597288587 Result: 25 passing / 7 failing — matches the current main/e2e baseline. Zero |
misha-db
approved these changes
Jul 2, 2026
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rugpanov
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Replaces Dependabot's #1946, which couldn't merge: its lockfile pinned
linkify-it@5.0.2— a version that doesn't exist on the public npm registry (latest is5.0.1) — soyarn install --immutablefailed in CI with a JFrog 403 (nothing upstream to serve). This PR regenerates the lockfile against real, published versions and takes the markdown-it major upgrade deliberately.What
markdown-itto^14.2.0.yarn.lockresolves to real versions: markdown-it 14.2.0, linkify-it 5.0.1, mdurl 2.0.0, punycode.js 2.3.1, uc.micro 2.1.0.dist/markdown-it.min.js) loaded by the Unity Catalog detail webview (resources/webview-ui/uc-detail.js):renderAPI is unchanged across v12→v14, and v14 still exposes thewindow.markdownitUMD global — no call-site changes needed. There's no TypeScript import of markdown-it and no@types/markdown-itdependency.Verification
yarn installregenerates cleanly; every resolved dep verified to exist on public npm (no phantom versions).yarn run buildpasses;package:copy-markdown-itships the v14markdown-it.min.jsintoout/.Backward compatibility: only the bundled markdown renderer version changes; webview API usage is identical. No persisted state, config, or public API change.
Closes #1946.
This pull request and its description were written by Isaac.