feat: import 17 skills from app-templates (ML-63273)#74
Closed
jamesbroadhead wants to merge 1 commit into
Closed
Conversation
Pull the agent-building skills from databricks/app-templates (.claude/skills/) into this repo so they can be installed via `databricks experimental aitools install` and reused across agent templates without manual syncing. Imported as flat top-level skills (one dir each): - add-tools-langgraph, add-tools-openai - agent-langgraph-memory, agent-openai-memory - create-tools, discover-tools - deploy, run-locally, quickstart - lakebase-setup, load-testing, long-running-server - migrate-from-model-serving - modify-langgraph-agent, modify-openai-agent - supervisor-api, supervisor-api-background-mode All marked `experimental: true` in the manifest pending the structural questions called out in the PR description (template variables, overlap with existing bundles, source-of-truth direction). Generated by `python3 scripts/skills.py generate`; passes `python3 scripts/skills.py validate`. Co-authored-by: Isaac Signed-off-by: James Broadhead <james.broadhead@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imports the 17 agent-building skills from
databricks/app-templatesinto this repo so they can be installed viadatabricks experimental aitools installinstead of being manually copied into each template via.scripts/sync-skills.py. Tracks ML-63273.Drafted because there are several structural decisions to resolve before this is mergeable — see Open questions below. Filing now so reviewers can weigh in on shape.
What's imported
17 new top-level skill dirs under
skills/, each withSKILL.md+agents/openai.yaml+ synced assets:add-tools-langgraph,add-tools-openai,create-tools,discover-toolsagent-langgraph-memory,agent-openai-memory,lakebase-setupmodify-langgraph-agent,modify-openai-agentquickstart,run-locally,deployload-testing,long-running-serversupervisor-api,supervisor-api-background-modemigrate-from-model-servingAll marked
experimental: trueinSKILL_METADATAuntil the questions below are resolved.Source:
~/checkouts/app-templates/.claude/skills/<name>/SKILL.md(source-of-truth for the sync), copied verbatim except: (a) frontmattername:aligned to the directory name (the source uses post-sync names likeadd-toolsfor both langgraph and openai variants), (b) addedmetadata.version: "0.0.1".1. Unresolved template variables
Six skills contain
{{...}}placeholders that the app-templates sync (.scripts/sync-skills.py) substitutes per-template:{{BUNDLE_NAME}}— replaced with each template's bundle name (e.g.agent_langgraph){{LAKEBASE_OPTIONS}},{{LAKEBASE_EXAMPLES}},{{LAKEBASE_CONFIGURES_ENV}},{{LAKEBASE_CONFIGURES_YML}}— conditional blocks included only for Lakebase-enabled templatesAffected:
add-tools-langgraph,add-tools-openai,deploy,lakebase-setup,quickstart,supervisor-api.Once installed via
databricks experimental aitools installthese placeholders will show up literally to the model. Options:{{BUNDLE_NAME}}with a generic placeholder like<bundle-name>and inline the Lakebase blocks unconditionally.2. Overlap with existing bundles
Three new skills overlap functionally with existing
databricks-*bundles:lakebase-setupdatabricks-lakebasemigrate-from-model-servingdatabricks-serverless-migration,databricks-model-servingdeploydatabricks-appsdatabricks-apps/SKILL.mdalready coversdatabricks bundle deployShould we (a) keep both and document the difference, (b) fold the new content into the existing bundles as references, or (c) rename to be unambiguous (e.g.
agent-lakebase-memory,migrate-model-serving-to-apps)?3. Structure mismatch with existing convention
The existing bundles (
databricks-apps,databricks-lakebase, …) use a bundle structure —SKILL.md+references/foo.md+references/bar.md. The imported skills are flat (oneSKILL.mdper dir). I dropped them in flat to keep the diff minimal and the migration mechanical, but the convention here is bundles.Options:
databricks-agents-langgraph/,databricks-agents-openai/,databricks-agents-common/, with the existing files moved underreferences/.databricks-app-templates/.4. Source-of-truth direction (post-merge)
Once merged, two copies exist: this repo and
app-templates/.claude/skills/. The end-state in ML-63273 (per Sid Murching's comment) is templates pulling fromdatabricks-agent-skillsviadatabricks experimental aitools install, but that flip needs:.claude/skills/and.scripts/sync-skills.pyI'd file the app-templates PR as a follow-up once the questions above land.
5. Naming: frontmatter
namevs source directoryIn
app-templates/.claude/skills/, the source dir names areadd-tools-langgraph/add-tools-openai/modify-langgraph-agent/modify-openai-agent/agent-langgraph-memory, but theirSKILL.mdfrontmatter uses the post-sync names (add-tools,modify-agent,agent-memory). I aligned the new skills' frontmatter to the directory name (the source-dir form) soscripts/skills.pydiscovery is consistent. Worth a sanity check.Test plan
python3 scripts/skills.py generate— syncs assets, regeneratesmanifest.jsonpython3 scripts/skills.py validate— passes (Everything is up to date.)databricks experimental aitools installagainst this branchRelated
databricks experimental aitools installrather than the per-template syncdatabricks-apps/databricks-lakebaseskillsThis pull request and its description were written by Claude.
Co-authored-by: Isaac