Skip to content

Group consecutive tool calls into a shared render block#190

Open
annzhang-db wants to merge 1 commit into
databricks:mainfrom
annzhang-db:parallel-tool-group-rendering
Open

Group consecutive tool calls into a shared render block#190
annzhang-db wants to merge 1 commit into
databricks:mainfrom
annzhang-db:parallel-tool-group-rendering

Conversation

@annzhang-db
Copy link
Copy Markdown

@annzhang-db annzhang-db commented Apr 17, 2026

Summary

  • Adds groupConsecutiveToolSegments to collapse runs of consecutive dynamic-tool segments into a single tool-group render block
  • Replaces the inline partSegments.map render loop with renderBlocks.map, routing tool groups to a new MessageToolGroup component
  • Extracts all tool rendering logic (MCP approval branch + regular tool branch) into a ToolPartRenderer component

Test plan

  • Verify single tool calls render identically to before
  • Verify consecutive tool calls are grouped into a shared wrapper
  • Verify MCP approval flow still works (approve/deny buttons, state transitions)
  • Verify OAuth inline errors still render correctly

https://ann-test-parallel-agent-6051921418418893.staging.aws.databricksapps.com/

Screen.Recording.2026-05-07.at.4.49.42.PM.mov

@annzhang-db annzhang-db force-pushed the parallel-tool-group-rendering branch from b0e0251 to 491145f Compare May 8, 2026 00:21
@annzhang-db annzhang-db requested a review from bbqiu May 8, 2026 20:59
@bbqiu
Copy link
Copy Markdown
Contributor

bbqiu commented May 13, 2026

in this demo video, they are all marked as completed at the same time. is this actually the case?

seems a little unlikely unless we're batching the consumption of the events into one update in the UI or some batching is happening on the SA side of things

Copy link
Copy Markdown
Contributor

@bbqiu bbqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but let's figure out what's going on w/ the batching of the requests: #190 (comment)

cna we also get AI to codify this behavior in a test (grouping of tool calls into one rendering block)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants