fix: reject unterminated quoted JSONPath fields - #106
Open
MichaelScofield wants to merge 1 commit into
Open
MichaelScofield wants to merge 1 commit into
MichaelScofield wants to merge 1 commit into
Conversation
Signed-off-by: luofucong <luofc@foxmail.com>
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unterminated double-quoted JSONPath fields such as
$."acurrently panic whenstring()slices past the end of its input. Require a closing quote before constructing the remainder slice so these inputs returnInvalidJsonPath.Adds regression cases for bare/bracketed fields, escaped quotes and backslashes, Unicode content, and filter expressions. The new regression cases fail with the original parser and pass with the fix.
Fixes #105.
Validation:
cargo test(199 tests including doctests)cargo test --no-default-features --features databend(194 tests including doctests)cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningsInvalidJsonPathfor all three malformed inputs; the valid quoted-field control still parses.