feat: add allocation-free scalar path visitors - #104
Merged
Merged
Conversation
sundy-li
approved these changes
Sep 2, 2026
sundy-li
left a comment
sundy-li
left a comment
Member
There was a problem hiding this comment.
Approved per reviewer request.
P1 note: this PR removes the public OwnedKeyPath::QuotedName(String) variant and maps quoted paths to Name(String). That is a downstream compatibility risk because existing consumers that construct or match QuotedName will fail to compile, and serialized/display representations may change. The PR tests and CI pass; this concern is about public API compatibility rather than current behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSONBscalar leaf paths and values without allocating an intermediate result vector.