chore: update tonic-reflection requirement from 0.13 to 0.14 - #144
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9464b45b07
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic = { version = "0.13", features = ["transport", "codegen", "tls-native-roots"] } | ||
| tonic-build = "0.13" | ||
| tonic-reflection = "0.13" | ||
| tonic-reflection = "0.14" |
There was a problem hiding this comment.
When building databend-meta, this pulls tonic-reflection 0.14 while the workspace still pins tonic/tonic-build/prost to 0.13. The reflection service built in crates/server/service/src/api/grpc_server.rs is passed to tonic 0.13's Server::builder().add_service(...), but tonic-reflection 0.14 is implemented against the 0.14 tonic/prost stack, so the service traits come from a different tonic version and the server package cannot type-check. Please either keep reflection at 0.13 or upgrade the whole tonic/prost stack together.
Useful? React with 👍 / 👎.
106469d to
5874bcf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5874bcf720
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic = { version = "0.13", features = ["transport", "codegen", "tls-native-roots"] } | ||
| tonic-build = "0.13" | ||
| tonic-reflection = "0.13" | ||
| tonic-reflection = "0.14" |
There was a problem hiding this comment.
Pinning tonic-reflection to 0.14 while the workspace still pins tonic/tonic-build to 0.13 introduces an incompatible mixed tonic stack: crates/server/service/src/api/grpc_server.rs builds a reflection service and passes it to tonic::transport::Server::builder().add_service(...), but that reflection service is typed against tonic 0.14 APIs. In builds that include this server crate, this causes trait/type mismatches at service wiring time, so the project no longer type-checks until the tonic family is upgraded together or reflection stays on 0.13.
Useful? React with 👍 / 👎.
5874bcf to
dd6eb93
Compare
dd6eb93 to
27d184a
Compare
Updates the requirements on [tonic-reflection](https://github.com/hyperium/tonic) to permit the latest version. - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/grpc/grpc-rust/blob/master/CHANGELOG.md) - [Commits](grpc/grpc-rust@v0.13.0...tonic-reflection-v0.14.6) --- updated-dependencies: - dependency-name: tonic-reflection dependency-version: 0.14.6 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
27d184a to
4c2fee5
Compare
Updates the requirements on tonic-reflection to permit the latest version.
Release notes
Sourced from tonic-reflection's releases.
Commits
6cb6056chore: release v0.14.6 (#2624)efde924grpc: change helloworld example to pass request as a view (#2632)d47b001transport: add max_frame_size to client Endpoint (#2592)02c01c7Allow setting the HTTP/2 client header table size (#2582)3185354examples: add grpc version of helloworld (#2630)f585303fix(grpc): Fix grpc-google build (#2628)ff7bcbbfeat(grpc): Google call credentials (#2610)f93037bfeat(tonic-xds): make XdsChannelGrpc Sync (#2627)d834bebgrpc: Update Status to be a Result<> and make StatusErr which holds non-OK co...2392224grpc: add route_guide example and make minor tweaks to the generated code API...