Skip to content

support wan27#117

Open
mose-zm wants to merge 3 commits intodashscope:mainfrom
mose-x:support_wan27
Open

support wan27#117
mose-zm wants to merge 3 commits intodashscope:mainfrom
mose-x:support_wan27

Conversation

@mose-zm
Copy link
Contributor

@mose-zm mose-zm commented Mar 10, 2026

support wan27

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the video synthesis capabilities by expanding the types of reference materials and media that can be provided as input. It introduces new parameters to the API calls and implements a more efficient, parallel file upload system. This change allows users to supply a broader range of assets for video generation, improving both flexibility and performance when dealing with local files.

Highlights

  • Enhanced Video Synthesis Inputs: Introduced new parameters reference_urls, reference_url, and media to the video synthesis call and async_call methods, allowing for more flexible input of reference materials and media files.
  • Parallel File Uploads: Refactored the internal file upload mechanism to utilize ThreadPoolExecutor, enabling parallel uploading of multiple reference videos, reference files, and media URLs, which significantly improves efficiency for requests with numerous local files.
  • New Constants for Media Types: Added REFERENCE_URLS and MEDIA_URLS constants to dashscope.common.constants to support the new input types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • dashscope/aigc/video_synthesis.py
    • Imported ThreadPoolExecutor and as_completed for concurrent operations.
    • Added REFERENCE_URLS and MEDIA_URLS to the imported constants.
    • Introduced reference_urls (List[str]), reference_url (str), and media (list) parameters to the call, async_call, and _get_input functions.
    • Updated docstrings for call and async_call to describe the new parameters.
    • Rewrote the file upload logic within _get_input to consolidate various URL types (img_url, audio_url, head_frame, tail_frame, first_frame_url, last_frame_url, reference_url, reference_video_urls, reference_urls, media) into a list of tasks.
    • Implemented a ThreadPoolExecutor to process these upload tasks concurrently, improving the efficiency of local file uploads.
    • Updated the input dictionary construction to correctly assign uploaded URLs based on their type (single, list_ref_video, list_ref_file, media).
  • dashscope/common/constants.py
    • Added new string constants REFERENCE_URLS and MEDIA_URLS.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request enhances the video synthesis API by introducing new parameters reference_urls, reference_url, and media to the call and async_call methods, updating their docstrings, and adding corresponding constants. A significant change involves refactoring the local file upload mechanism within the _get_input function to utilize a ThreadPoolExecutor for concurrent processing of various media and reference URLs, improving efficiency. A review comment suggests improving the docstring for reference_url by adding parentheses around its type hint for consistency.

audio_url (str): The input audio url
reference_video_urls (List[str]): list of character reference video file urls uploaded by the user # pylint: disable=line-too-long
reference_urls (List[str]): list of character reference file urls uploaded by the user # pylint: disable=line-too-long
reference_url str: reference file url uploaded by the user # pylint: disable=line-too-long

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The type hint for reference_url in the docstring is missing parentheses. It should be (str) instead of str for consistency with other type hints in the docstring.

Suggested change
reference_url str: reference file url uploaded by the user # pylint: disable=line-too-long
reference_url (str): reference file url uploaded by the user # pylint: disable=line-too-long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant