fix: __getattr__ raises AttributeError instead of KeyError

[marklysze]

Summary

• DashScopeAPIResponse.__getattr__ raised KeyError when an attribute was missing, breaking getattr(obj, name, default) and hasattr(obj, name) which rely on AttributeError for fallback behavior
• Wraps the dict lookup in a try/except to convert KeyError to AttributeError

Closes #114

Test plan

• getattr(response.output, "reasoning_content", None) returns None instead of raising KeyError
• hasattr(response.output, "reasoning_content") returns False instead of raising KeyError
• Existing attribute access still works normally

Happy to add unit tests for this if preferred.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where accessing a non-existent attribute on a DashScopeAPIResponse object incorrectly raised a KeyError. The change modifies the __getattr__ method to catch KeyError and re-raise it as an AttributeError, which is the standard Python exception for missing attributes. This fix ensures that built-in functions like getattr() with a default value and hasattr() behave as expected, providing more robust and predictable attribute access.

Highlights

• Corrected getattr behavior: Modified DashScopeAPIResponse.__getattr__ to raise AttributeError instead of KeyError when an attribute is missing, aligning with Python's expected behavior for attribute access.
• Improved compatibility: Ensures getattr(obj, name, default) and hasattr(obj, name) now function as intended, preventing unexpected KeyError exceptions when checking for non-existent attributes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• dashscope/api_entities/dashscope_response.py
  • Changed __getattr__ to catch KeyError and re-raise as AttributeError.

Activity

• Addressed issue DashScopeAPIResponse.__getattr__ raises KeyError instead of AttributeError #114 by implementing the fix.
• Provided a test plan demonstrating the corrected behavior for getattr and hasattr.
• Offered to add unit tests if desired by reviewers.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses the issue where DashScopeAPIResponse.__getattr__ was raising a KeyError instead of an AttributeError for missing attributes. The change to catch KeyError and re-raise it as AttributeError aligns with Python's expected behavior for attribute access, ensuring compatibility with functions like getattr(obj, name, default) and hasattr(obj, name). The use of from None is also good practice to prevent exception chaining.