Skip to content

fix: handle and propagate errors in event channel monitors

1f3f4c0
Select commit
Loading
Failed to load commit list.
Draft

fix: handle and propagate errors in event channel monitors #573

fix: handle and propagate errors in event channel monitors
1f3f4c0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 23, 2026 in 0s

66.55% (+0.22%) compared to 19fb152

View this Pull Request on Codecov

66.55% (+0.22%) compared to 19fb152

Details

Codecov Report

❌ Patch coverage is 82.77635% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.55%. Comparing base (19fb152) to head (1f3f4c0).
⚠️ Report is 3 commits behind head on refactor/move-callbacks-to-crates.

Files with missing lines Patch % Lines
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 38 Missing ⚠️
dash-spv/src/main.rs 0.00% 13 Missing ⚠️
dash-spv/src/client/event_handler.rs 97.04% 7 Missing ⚠️
dash-spv/src/client/sync_coordinator.rs 85.71% 7 Missing ⚠️
dash-spv-ffi/src/client.rs 92.00% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           refactor/move-callbacks-to-crates     #573      +/-   ##
=====================================================================
+ Coverage                              66.32%   66.55%   +0.22%     
=====================================================================
  Files                                    311      312       +1     
  Lines                                  64976    65058      +82     
=====================================================================
+ Hits                                   43097    43298     +201     
+ Misses                                 21879    21760     -119     
Files with missing lines Coverage Δ
dash-spv-ffi/src/callbacks.rs 80.70% <100.00%> (+17.23%) ⬆️
dash-spv/src/client/events.rs 100.00% <100.00%> (ø)
dash-spv/src/client/mod.rs 98.64% <ø> (ø)
dash-spv-ffi/src/client.rs 58.85% <92.00%> (-0.53%) ⬇️
dash-spv/src/client/event_handler.rs 97.04% <97.04%> (ø)
dash-spv/src/client/sync_coordinator.rs 80.55% <85.71%> (+7.82%) ⬆️
dash-spv/src/main.rs 0.00% <0.00%> (ø)
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes