Skip to content

feat(dash-spv): add notify_wallet_addresses_changed() API #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lklimek wants to merge 7 commits into
base: feat/mempool-support
Choose a base branch
from

test(dash-spv): add failing tests for mempool blocked by masternode sync

8e6e267
Select commit
Loading
Failed to load commit list.
Draft

feat(dash-spv): add notify_wallet_addresses_changed() API #567

test(dash-spv): add failing tests for mempool blocked by masternode sync
8e6e267
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 20, 2026 in 1s

67.29% (+0.92%) compared to 1de2479

View this Pull Request on Codecov

67.29% (+0.92%) compared to 1de2479

Details

Codecov Report

❌ Patch coverage is 91.60457% with 169 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.29%. Comparing base (1de2479) to head (8e6e267).
⚠️ Report is 8 commits behind head on feat/mempool-support.

Files with missing lines Patch % Lines
dash-spv/src/sync/mempool/sync_manager.rs 87.21% 51 Missing ⚠️
dash-spv/src/sync/mempool/manager.rs 97.55% 25 Missing ⚠️
dash-spv/src/sync/progress.rs 36.11% 23 Missing ⚠️
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 17 Missing ⚠️
dash-spv-ffi/src/callbacks.rs 29.16% 17 Missing ⚠️
key-wallet-manager/src/wallet_manager/mod.rs 81.08% 7 Missing ⚠️
dash-spv/src/sync/sync_coordinator.rs 45.45% 6 Missing ⚠️
key-wallet-manager/src/events.rs 0.00% 6 Missing ⚠️
dash-spv/src/client/events.rs 0.00% 4 Missing ⚠️
...wallet-manager/src/wallet_manager/process_block.rs 96.66% 4 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           feat/mempool-support     #567      +/-   ##
========================================================
+ Coverage                 66.37%   67.29%   +0.92%     
========================================================
  Files                       311      316       +5     
  Lines                     64979    66972    +1993     
========================================================
+ Hits                      43130    45070    +1940     
- Misses                    21849    21902      +53
Files with missing lines Coverage Δ
dash-spv-ffi/src/types.rs 92.85% <100.00%> (+0.70%) ⬆️
dash-spv/src/client/lifecycle.rs 64.81% <100.00%> (+1.35%) ⬆️
dash-spv/src/network/mod.rs 72.72% <100.00%> (+23.36%) ⬆️
dash-spv/src/sync/blocks/manager.rs 94.82% <100.00%> (+0.09%) ⬆️
dash-spv/src/sync/identifier.rs 100.00% <100.00%> (ø)
dash-spv/src/sync/mempool/progress.rs 100.00% <100.00%> (ø)
...wallet/src/transaction_checking/account_checker.rs 64.01% <100.00%> (+0.05%) ⬆️
...-wallet/src/transaction_checking/wallet_checker.rs 95.42% <ø> (+0.31%) ⬆️
...allet/managed_wallet_info/wallet_info_interface.rs 79.48% <100.00%> (+10.18%) ⬆️
dash-spv/src/network/manager.rs 63.19% <0.00%> (+1.69%) ⬆️
... and 16 more

... and 8 files with indirect coverage changes

View more details on Codecov