Skip to content

feat: add mempool support #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xdustinface wants to merge 3 commits into
base: feat/transaction-status-events
Choose a base branch
from

fix: activate mempool on `FiltersSyncComplete` instead of waiting for…

450f72f
Select commit
Loading
Failed to load commit list.
Draft

feat: add mempool support #558

fix: activate mempool on `FiltersSyncComplete` instead of waiting for…
450f72f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 24, 2026 in 0s

67.46% (+1.06%) compared to 7cf7b6c

View this Pull Request on Codecov

67.46% (+1.06%) compared to 7cf7b6c

Details

Codecov Report

❌ Patch coverage is 94.97806% with 103 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.46%. Comparing base (7cf7b6c) to head (450f72f).

Files with missing lines Patch % Lines
key-wallet-ffi/src/transaction.rs 0.00% 26 Missing ⚠️
dash-spv/src/sync/mempool/manager.rs 97.55% 25 Missing ⚠️
key-wallet/src/manager/process_block.rs 92.39% 13 Missing ⚠️
key-wallet/src/manager/mod.rs 74.19% 8 Missing ⚠️
dash-spv/src/sync/mempool/sync_manager.rs 98.76% 6 Missing ⚠️
key-wallet/src/managed_account/mod.rs 78.57% 6 Missing ⚠️
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 5 Missing ⚠️
key-wallet/src/manager/wallet_interface.rs 0.00% 3 Missing ⚠️
...allet/managed_wallet_info/wallet_info_interface.rs 50.00% 3 Missing ⚠️
dash-spv/src/sync/mempool/filter.rs 97.89% 2 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@                        Coverage Diff                         @@
##           feat/transaction-status-events     #558      +/-   ##
==================================================================
+ Coverage                           66.40%   67.46%   +1.06%     
==================================================================
  Files                                 312      316       +4     
  Lines                               65128    67142    +2014     
==================================================================
+ Hits                                43246    45300    +2054     
+ Misses                              21882    21842      -40
Files with missing lines Coverage Δ
dash-spv-ffi/src/types.rs 92.85% <100.00%> (+0.70%) ⬆️
dash-spv/src/network/mod.rs 72.72% <100.00%> (+23.36%) ⬆️
dash-spv/src/sync/blocks/manager.rs 94.82% <100.00%> (+0.09%) ⬆️
dash-spv/src/sync/events.rs 62.50% <ø> (+5.00%) ⬆️
dash-spv/src/sync/identifier.rs 100.00% <100.00%> (ø)
dash-spv/src/sync/mempool/progress.rs 100.00% <100.00%> (ø)
dash-spv/src/sync/sync_coordinator.rs 85.15% <100.00%> (+0.33%) ⬆️
...-wallet/src/transaction_checking/wallet_checker.rs 95.42% <ø> (ø)
dash-spv-ffi/src/callbacks.rs 60.07% <83.33%> (+0.16%) ⬆️
dash-spv/src/client/lifecycle.rs 64.67% <90.90%> (+1.21%) ⬆️
... and 14 more

... and 9 files with indirect coverage changes

View more details on Codecov