test(dpp): restore ~60 commented-out/ignored tests#3122
Open
thepastaclaw wants to merge 12 commits intodashpay:v3.1-devfrom
Open
test(dpp): restore ~60 commented-out/ignored tests#3122thepastaclaw wants to merge 12 commits intodashpay:v3.1-devfrom
thepastaclaw wants to merge 12 commits intodashpay:v3.1-devfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Restore ~60 commented-out, ignored, and broken tests in
rs-dppthat were silently disabled during API migrations. These tests cover critical paths: signing/validation, serialization, schema validation, and document factory operations.Tracking issue: thepastaclaw/tracker#12.
What was done?
Nine incremental commits, one per fix area:
#[test]attributes toschema_defstests in v0/v1DocumentTypeV0instead ofDocumentTypeV1intry_from_schema/v1#[ignore]from 6recursive_schema_validatortestsDataContractV0serialization tests (updated to current API)DataContractUpdateTransitionJSON conversion testDocumentFactorytests (updated to current API)How Has This Been Tested?
cargo test -p dpp --lib→ 523 passed, 0 failedcargo test -p dpp(including doctests) → all passValidation
All DPP-related CI checks pass on the head commit (
893becfe):Downstream packages also pass (confirming no ripple effects from test-only changes):
Two pre-existing CI failures unrelated to this PR:
Local validation (pre-push):
cargo test -p dpp --lib— 523 tests passed, 0 failedcargo test -p dpp(full, including doctests) — all passBreaking Changes
None. This PR contains only test code changes.
Checklist:
For repository code-owners and collaborators only