fix: replace broken Google Sheets links with subsidy calculator#574
fix: replace broken Google Sheets links with subsidy calculator#574thepastaclaw wants to merge 2 commits intodashpay:23.0.0from
Conversation
Replace two broken Google Spreadsheet links in the emission/subsidy section with the new interactive Dash Block Subsidy Calculator. Closes dashpay#573
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaced two external Google Sheets links in the features documentation with a single self-hosted Dash subsidy calculator URL ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/user/introduction/features.rst (1)
397-397: Deduplicate the repeated calculator URL using a named RST target.The calculator link appears at both line 369 and line 397. Defining a named hyperlink target avoids maintenance issues if the URL changes again.
♻️ Proposed refactor
+.. _dash-subsidy-calculator: https://thepastaclaw.github.io/dash-subsidy-calculator/ + ... -block subsidy is reduced at regular intervals, as `shown -in this calculation -<https://thepastaclaw.github.io/dash-subsidy-calculator/>`_. +block subsidy is reduced at regular intervals, as `shown +in this calculation <dash-subsidy-calculator_>`_. ... -`Dash's total coin emission <https://thepastaclaw.github.io/dash-subsidy-calculator/>`_ is +`Dash's total coin emission <dash-subsidy-calculator_>`_ is🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/user/introduction/features.rst` at line 397, Define a single named reStructuredText hyperlink target for the Dash calculator (e.g., use a target like ".. _dash_calculator: https://thepastaclaw.github.io/dash-subsidy-calculator/") near the top of the document and replace both inline occurrences of the full URL (`Dash's total coin emission <https://thepastaclaw.github.io/dash-subsidy-calculator/>`_) with the named reference using the target label (`Dash's total coin emission <dash_calculator_>`_), ensuring both line 369 and line 397 now reference the same named target.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/user/introduction/features.rst`:
- Line 397: Define a single named reStructuredText hyperlink target for the Dash
calculator (e.g., use a target like ".. _dash_calculator:
https://thepastaclaw.github.io/dash-subsidy-calculator/") near the top of the
document and replace both inline occurrences of the full URL (`Dash's total coin
emission <https://thepastaclaw.github.io/dash-subsidy-calculator/>`_) with the
named reference using the target label (`Dash's total coin emission
<dash_calculator_>`_), ensuring both line 369 and line 397 now reference the
same named target.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5db27f11-8dbb-45cc-b00f-d35f1a89856e
📒 Files selected for processing (1)
docs/user/introduction/features.rst
It's hosted on GitHub, but it's still a step forward, because it works. |
|
Fair point — "self-hosted" is a stretch when it's on GitHub Pages. The key bit is that it actually works, unlike the old Sheets links. 😄 |
2 participants
Replaces two broken Google Spreadsheet links in the emission/subsidy section with the new interactive Dash Block Subsidy Calculator.
The old Google Sheets links (referenced in #573) return errors — the new calculator is self-hosted and covers block subsidy, reward allocation by era, and emission curve.
Closes #573
Preview build: https://dash-docs--574.org.readthedocs.build/en/574/
Summary by CodeRabbit