Adding support for Build Daemon + Frontend Server with expression eval.#2836
Draft
Markzipan wants to merge 33 commits into
Draft
Adding support for Build Daemon + Frontend Server with expression eval.#2836Markzipan wants to merge 33 commits into
Markzipan wants to merge 33 commits into
Conversation
1 task
b86e719 to
79b7fa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes at a glance:
DWDS
ddc_uri_translator.dartDdcUriTranslator, which translates paths between FES and package:build asset URI formats (e.g., mapping.dart.libsuffixes to.ddc, handling packagelib/segment inclusion/exclusion, etc.).frontend_server_strategy_provider.dartFrontendServerBuildDaemonStrategyProviderto translate/remap FES and build daemon paths and other conventions.daemon_expression_compiler.dartDaemonExpressionCompiler, which forwards expression evaluation requests to the instantiated Frontend Server worker via socket.location.dartorg-dartlang-appand other bits).Webdev and Serving Workflow
dev_workflow.dartbuild_frontend_server:fes_managersubprocess whenwebHotReloadis enabled. This creates a persistent shared Frontend Server (with a persistent scratch space) that can receive expression eval, hot reload, and hot restart requests while allowing communication with the build daemon.webdev_server.dartFrontendServerBuildDaemonStrategyProviderwhenwebHotReload. Also write a specialfes_manager_configto signal to build runner that a shared FES should be used.Tests
context.dart_createBuildRunnerDdcLibraryBundleAssetHandlerto serve compiled outputs directly from the build cache or scratch space via multi-roots.reloaded_source.json. This is unlike a real app but works well for the test fixtures.build_web_compilersto4.8.2in test fixtures.Depends on dart-lang/build#4979