Avoid inline styles in chart scripts#9220
Open
sigurdm wants to merge 1 commit intodart-lang:masterfrom
Open
Conversation
isoos
reviewed
Feb 16, 2026
|
|
||
| void hideCursor(_) { | ||
| cursor.setAttribute('style', 'opacity:0'); | ||
| toolTip.setAttribute('style', 'opacity:0;position:absolute;'); |
Collaborator
There was a problem hiding this comment.
position: absolute is missing.
Contributor
Author
There was a problem hiding this comment.
I wonder if that matters when the opacity is 0.
Member
There was a problem hiding this comment.
it might matter a bit if there is a CSS transition on the opacity :D
Open
isoos
approved these changes
Feb 16, 2026
jonasfj
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.