feat: Improve the output of release emails#9218
Merged
Conversation
Format the changelog excerpt like code
Member
Author
|
I really want this to be better 
From https://pub.dev/packages/gma_mediation_bidmachine/changelog |
Contributor
|
This will render something like this I think: |
sigurdm
reviewed
Feb 16, 2026
| String _changeLogDiv(String excerpt) => | ||
| ''' | ||
| Excerpt of the changelog:<br/> | ||
| <div style="background-color: #f6f8fa; border-radius: 6px; padding: 16px; overflow: auto; border: 1px solid #d0d7de; margin: 20px 0;"> |
Contributor
There was a problem hiding this comment.
It hurts me to see sizes in px. I wonder if we can use font-relative units, such that the default font size of the email client has effect. And if that is worth it.
Excerpt of the changelog:<br/><div style="background-color: #f6f8fa; border-radius: .5rem; padding: 2rem; overflow: auto; border: 1px solid #d0d7de; margin: 3rem 0;">
<pre style="margin: 0; font-family: 'Courier New', Courier, monospace; font-size: 1rem; line-height: 1.5; color: #24292f;">
Member
Author
|
Can we land this? Who can review? |
sigurdm
approved these changes
Feb 17, 2026
Contributor
|
How the mail looks now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format the changelog excerpt like code