-
Notifications
You must be signed in to change notification settings - Fork 103
[ffigen] allow isA (null) to return false for ObjCobject #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
liamappelbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This just needs some changelog entries and version bumps:
- FFIgen just needs a CHANGELOG.md entry
- objective_c needs a minor version bump, to
9.4.0-wip, in the pubspec.yaml, and a corresponding CHANGELOG.md entry - No changelog entry needed for swiftgen
|
Ok. I’ll version bump objective_c and add the FFIgen objective_c changelog entry in the next commit. |
53024ca to
099942d
Compare
099942d to
84d3bd4
Compare
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
|
Looks like you need to It's a bit weird though. FFIgen is supposed to auto-format the bindings when they're regenerated. I'm guessing they were manually updated instead of regenerated? |
Fixes Issue: #2877
Details