Remote service enhancement (applied to updated SlimBrowse Metadata)

.devcontainer/Dockerfile

@@ -0,0 +1,15 @@
+FROM mcr.microsoft.com/devcontainers/base:bookworm
+
+# taken from: https://github.com/LMS-Community/slimserver-platforms/blob/public/9.1/Docker/Dockerfile
+
+# Set environment variables
+ENV DEBIAN_FRONTEND=noninteractive
+ENV LC_ALL="C.UTF-8" LANG="en_US.UTF-8" LANGUAGE="en_US.UTF-8"
+
+
+# Install packages
+RUN sudo apt-get update -qq  && \
+	sudo apt-get install --no-install-recommends -qy procps psmisc wget curl perl tzdata libcrypt-blowfish-perl libwww-perl libfont-freetype-perl liblinux-inotify2-perl \
+	libdata-dump-perl libio-socket-ssl-perl libnet-ssleay-perl libcrypt-ssleay-perl libcrypt-openssl-rsa-perl libssl-dev libgomp1 libasound2 lame opus-tools && \
+	sudo apt-get clean -qy && \
+	sudo rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

.devcontainer/devcontainer.json

@@ -0,0 +1,36 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/debian
+{
+	"name": "Lyrion Debian devcontainer",
+	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+	//"image": "mcr.microsoft.com/devcontainers/base:bookworm",
+	"dockerComposeFile": "docker-compose.yml",
+	"service": "lyrion-devcontainer",
+	"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
+	// Features to add to the dev container. More info: https://containers.dev/features.
+	// "features": {},
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	"forwardPorts": [
+		9000,
+		3483,
+		9090
+	],
+	"portsAttributes": {
+		"9000": {
+			"label": "web interface",
+			"protocol": "http"
+		},
+		"3483": {
+			"label": "SlimProto"
+		},
+		"9090": {
+			"label": "CLI"
+		}
+	},
+	// Use 'postCreateCommand' to run commands after the container is created.
+	"postCreateCommand": "/workspaces/slimserver/.devcontainer/post-create.sh"
+	// Configure tool-specific properties.
+	// "customizations": {},
+	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+	// "remoteUser": "root"
+}

.devcontainer/docker-compose.yml

@@ -0,0 +1,16 @@
+version: '3.11'
+
+services:
+  lyrion-devcontainer:
+    # add this line so we can connect to the host machine
+    build:
+      context: .
+      dockerfile: Dockerfile
+    volumes:
+     - lyrion-dev-volume:/workspace
+
+    # Overrides default command so things don't shut down after the process ends.
+    command: sleep infinity
+
+volumes:
+  lyrion-dev-volume:

.devcontainer/post-create.sh

@@ -0,0 +1,21 @@
+#!/bin/bash
+set -e
+
+# get current git branch
+BRANCH="$(git rev-parse --abbrev-ref HEAD)"
+
+URL_BRANCH="https://raw.githubusercontent.com/LMS-Community/slimserver-platforms/${BRANCH}/Docker/Slim-Utils-OS-Custom.pm"
+URL_HEAD="https://raw.githubusercontent.com/LMS-Community/slimserver-platforms/HEAD/Docker/Slim-Utils-OS-Custom.pm"
+TARGET_FILE="/workspaces/slimserver/Slim/Utils/OS/Custom.pm"
+
+echo "Detected branch: ${BRANCH}"
+echo "Trying branch-specific file..."
+
+# Try downloading branch version
+if curl -fSL "$URL_BRANCH" -o "$TARGET_FILE"; then
+    echo "Downloaded branch version from: $URL_BRANCH"
+else
+    echo "Branch file not found, falling back to HEAD..."
+    curl -fSL "$URL_HEAD" -o "$TARGET_FILE"
+    echo "Downloaded latest version from: $URL_HEAD"
+fi

.github/ISSUE_TEMPLATE/bug_report.md

@@ -25,10 +25,12 @@ If applicable, add screenshots to help explain your problem.
 
 **System Information (please complete the following information):**
  - OS on which you're running LMS: [e.g. pCP 10]
+ - Hardware on which you're running LMS (x86_64, aarch64, ARM, ...)
  - Web skin used: [e.g. Material, Default]
- - Browser [e.g. chrome, safari]
- - LMS Version [e.g. 22]
+ - Browser [e.g. Chrome, Safari]
+ - LMS Version
  - Player(s) involved
+ - Addition information from the Settings/Information header section
 
 **Additional context**
 Add any other context about the problem here. E.g. a `server.log` or `scanner.log` snippet (see Settings/Information in your LMS)

.github/actions/build/action.yaml

@@ -13,6 +13,16 @@ inputs:
     description: The key ID to use to upload to S3
   AWS_SECRET_ACCESS_KEY:
     description: The secret to use to upload to S3
+  SIGNPATH_API_TOKEN:
+    description: The SignPath API token to use for code signing
+  SIGNPATH_ORG_ID:
+    description: The SignPath organization ID to use for code signing
+  SIGNPATH_PROJECT_SLUG:
+    description: The SignPath project slug to use for code signing
+  SIGNPATH_SIGNING_POLICY_SLUG:
+    description: The SignPath signing policy slug to use for code signing
+  SIGNPATH_ARTIFACT_CONFIG_SLUG:
+    description: The SignPath artifact config slug to use for code signing
 
 runs:
   using: composite
@@ -33,7 +43,7 @@ runs:
 
 
     - name: Check out LMS platform code
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         repository: ${{ github.repository_owner }}/slimserver-platforms
         path: platforms
@@ -42,7 +52,7 @@ runs:
 
     - name: Check out pCP platform code
       if: ${{ startsWith(inputs.build-params, 'pcp') }}
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         repository: picoreplayer/lms-update-script
         path: platforms/pcp
@@ -120,12 +130,14 @@ runs:
         fi
 
     - name: Cache s5cmd
-      uses: actions/cache@v4
+      if: ${{ !startsWith(inputs.build-params, 'docker') }}
+      uses: actions/cache@v5
       with:
         key: s5cmd-${{ runner.os }}
         path: ${{ runner.temp }}/s5cmd-bin
 
     - name: Check if s5cmd is installed
+      if: ${{ !startsWith(inputs.build-params, 'docker') }}
       id: check-s5cmd
       continue-on-error: true
       shell: bash
@@ -151,11 +163,35 @@ runs:
 
     - name: Archive artifacts
       if: ${{ !startsWith(inputs.build-params, 'docker') }}
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v6
+      id: upload-artifact
       with:
         name: ${{ inputs.build-params }}
         path: publish
 
+    - name: Prepare Windows release signing
+      if: ${{ startsWith(inputs.build-params, 'win64') && inputs.build-type == 'release' }}
+      uses: signpath/github-action-submit-signing-request@v2
+      with:
+        api-token: '${{ inputs.SIGNPATH_API_TOKEN }}'
+        organization-id: '${{ inputs.SIGNPATH_ORG_ID }}'
+        project-slug: '${{ inputs.SIGNPATH_PROJECT_SLUG }}'
+        signing-policy-slug: '${{ inputs.SIGNPATH_SIGNING_POLICY_SLUG }}'
+        artifact-configuration-slug: '${{ inputs.SIGNPATH_ARTIFACT_CONFIG_SLUG }}'
+        github-artifact-id: '${{ steps.upload-artifact.outputs.artifact-id }}'
+        wait-for-completion: true
+        output-artifact-directory: publish
+
+    - name: Calculate hash for signed Windows binary
+      if: ${{ startsWith(inputs.build-params, 'win64') && inputs.build-type == 'release' }}
+      shell: bash
+      run: |
+        cd publish
+        for f in LyrionMusicServer-*exe;
+        do
+          md5sum $f > $f.md5
+        done
+
     - name: Upload artifacts to R2
       if: ${{ !startsWith(inputs.build-params, 'docker') && github.repository_owner == 'LMS-Community' }}
       shell: bash

.github/workflows/00_build.yaml

@@ -35,7 +35,7 @@ jobs:
     steps:
       # we must check out here, as  otherwise the build action is not available
       - name: Check out LMS code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           path: server
           ref: ${{ inputs.branch }}
@@ -89,16 +89,17 @@ jobs:
     steps:
       # we must check out here, as  otherwise the build action is not available
       - name: Check out LMS code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           path: server
           ref: ${{ inputs.branch }}
 
       - name: Prepare build environment
         if: ${{ matrix.flavour[0] != 'tarball' && matrix.flavour[0] != 'pcp' }}
-        run: |
-          sudo apt update
-          sudo apt install -y apt-transport-https debhelper devscripts
+        uses: awalsh128/cache-apt-pkgs-action@latest
+        with:
+          packages: apt-transport-https debhelper devscripts
+          version: 1
 
       - name: Launch build process
         uses: ./server/.github/actions/build
@@ -115,7 +116,7 @@ jobs:
     steps:
       # we must check out here, as  otherwise the build action is not available
       - name: Check out LMS code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           path: server
           ref: ${{ inputs.branch }}
@@ -148,7 +149,7 @@ jobs:
     steps:
       # we must check out here, as  otherwise the build action is not available
       - name: Check out LMS code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           path: server
           ref: ${{ inputs.branch }}
@@ -160,6 +161,21 @@ jobs:
           build-type: ${{ inputs.build_type }}
           AWS_KEY_ID: ${{ secrets.R2_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }}
+          SIGNPATH_API_TOKEN: ${{ secrets.SIGNPATH_API_TOKEN }}
+          SIGNPATH_ORG_ID: ${{ vars.SIGNPATH_ORG_ID }}
+          SIGNPATH_PROJECT_SLUG: ${{ vars.SIGNPATH_PROJECT_SLUG }}
+          SIGNPATH_SIGNING_POLICY_SLUG: ${{ vars.SIGNPATH_SIGNING_POLICY_SLUG }}
+          SIGNPATH_ARTIFACT_CONFIG_SLUG: ${{ vars.SIGNPATH_ARTIFACT_CONFIG_SLUG }}
+
+      - name: Archive signed Windows artifact
+        # we only sign for release builds - no need to do this for nightlies
+        if: ${{ inputs.build-type == 'release' }}
+        # needs to be run here as the above build action can't run upload twice
+        uses: actions/upload-artifact@v6
+        id: upload-artifact
+        with:
+          name: win64-signed
+          path: publish/
 
   updateRepoFile:
     name: Trigger repository file update

.github/workflows/00_smoketest.yaml

@@ -18,13 +18,19 @@ jobs:
             exit 1
           fi
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: Install dependencies
+        if: ${{ !env.ACT }}
+        uses: awalsh128/cache-apt-pkgs-action@latest
+        with:
+          packages: libio-socket-ssl-perl libnet-ssleay-perl netcat-traditional
+          version: 1
+
+      - name: Install dependencies (ACT fallback)
+        if: ${{ env.ACT }}
         run: |
-          if [ "$ACT" == "true" ]; then
-            sudo apt-get update
-          fi
+          sudo apt-get update
           sudo apt-get install -y libio-socket-ssl-perl libnet-ssleay-perl netcat-traditional
 
       - name: Test Strings File

.github/workflows/close-stale-issues.yaml

@@ -9,14 +9,18 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       issues: write
+      pull-requests: write
     steps:
-      - uses: actions/stale@v9
+      - uses: actions/stale@v10
         with:
           days-before-issue-stale: 720
           days-before-issue-close: 14
           stale-issue-label: "stale"
           stale-issue-message: ":warning: This issue is stale because it has been open for 720 days with no activity. Please chime in if you want to keep it alive."
           close-issue-message: ":no_entry: This issue was closed because it has been inactive for 14 days since being marked as stale."
-          days-before-pr-stale: -1
-          days-before-pr-close: -1
+          days-before-pr-stale: 720
+          days-before-pr-close: 14
+          stale-pr-label: "stale"
+          stale-pr-message: ":warning: This pull request is stale because it has been open for 720 days with no activity. Please chime in if you want to keep it alive."
+          close-pr-message: ":no_entry: This pull request was closed because it has been inactive for 14 days since being marked as stale."
           repo-token: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -0,0 +1,8 @@
+# Ignore custom OS module as this is installed in devcontainer and not part of this repo
+Slim/Utils/OS/Custom.pm
+
+# Ignore cache, logs and prefs files
+Cache/*
+Logs/*
+prefs/*
+Plugins/*