Repository navigation
stop: move stop signal to control endpoint - #42
Merged
Merged
Conversation
s23b
changed the title
s23b
marked this pull request as ready for review
September 30, 2026 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stopcommand relied on the heartbeat mechanism to trigger the stopping of an emulator.Now that the button interaction introduced a need for a direct channel to running emulators, this control channel can also be used to trigger a stop synchronously instead of relying on the registry to eventually send the stop signal to the emulator as a heartbeat response. This makes the
stopcommand much faster, and the implementation more straight-forward.