Skip to content

fix(clients): accept PATCH in InvokeMethodRequest - #1351

Merged
dapr-bot merged 2 commits into
dapr:mainfrom
VictorMoni:fix/invoke-request-patch-verb
Nov 6, 2026
Merged

dapr-bot merged 2 commits into
dapr:mainfrom
VictorMoni:fix/invoke-request-patch-verb

Conversation

@VictorMoni

Copy link
Copy Markdown
Contributor

Description

InvokeMethodRequest.http_verb = 'PATCH' raised ValueError because PATCH was missing from the request object's HTTP verb allowlist, even though the SDK's HTTP extension enum supports it. Add PATCH to that list.

Add regression coverage for accepting PATCH, rejecting invalid verbs, and clearing a configured verb. This change concerns the request object's setter; public gRPC invocation already recognizes PATCH.

Issue reference

Closes #1350.

Validation

  • Reproduced the PATCH failure with the new test before applying the fix.
  • Full unit suite: 2175 passed, 41 deselected, 188 subtests passed (Python 3.12; integration and example suites excluded).
  • ruff check: passed.
  • ruff format --check: 538 files already formatted.
  • mypy: no issues in 230 source files.
  • git diff --check: passed.
  • The test process logged an OpenTelemetry exporter shutdown warning after the passing summary.

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Reviewed documentation; no documentation changes needed for this validation fix

RELEASE NOTE: FIX Accept PATCH in InvokeMethodRequest HTTP verb validation.

Signed-off-by: victormoni <victor-moni@hotmail.com>
@VictorMoni
VictorMoni requested review from a team as code owners November 2, 2026 12:54
@CasperGN CasperGN self-assigned this Nov 2, 2026

@sicoyle sicoyle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find! Thank you for this and for your interest in the Dapr Open Source project and community! Thank youu! 🚀

@sicoyle sicoyle added automerge allows dapr bot to merge a PR after tests pass autoupdate labels Nov 6, 2026
@dapr-bot
dapr-bot enabled auto-merge November 6, 2026 15:19
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.65%. Comparing base (6e26a49) to head (425e08e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
+ Coverage   88.61%   88.65%   +0.04%     
==========================================
  Files         165      165              
  Lines       13540    13540              
==========================================
+ Hits        11998    12004       +6     
+ Misses       1542     1536       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dapr-bot
dapr-bot added this pull request to the merge queue Nov 6, 2026
Merged via the queue into dapr:main with commit 3ea58af Nov 6, 2026
30 checks passed
@VictorMoni

VictorMoni commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Thank you so much for the review, @sicoyle, and for your support, @CasperGN! 😊

I'm really happy to contribute to the Dapr open-source community!

I was also wondering if there's a Holopin badge available for SDK contributors. If so, could either of you point me to how I can claim it?

Thanks again! 🚀

@sicoyle

sicoyle commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Thank you so much for the review, @sicoyle, and for your support, @CasperGN! 😊

I'm really happy to contribute to the Dapr open-source community!

I was also wondering if there's a Holopin badge available for SDK contributors. If so, could either of you point me to how I can claim it?

Thanks again! 🚀

There absolutely is!! @marcduiker could you please help a friend here? 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge allows dapr bot to merge a PR after tests pass autoupdate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] InvokeMethodRequest.http_verb rejects PATCH

4 participants