Repository navigation
fix(clients): accept PATCH in InvokeMethodRequest - #1351
Merged
Merged
Conversation
Signed-off-by: victormoni <victor-moni@hotmail.com>
sicoyle
approved these changes
Nov 6, 2026
sicoyle
left a comment
Contributor
There was a problem hiding this comment.
great find! Thank you for this and for your interest in the Dapr Open Source project and community! Thank youu! 🚀
dapr-bot
enabled auto-merge
November 6, 2026 15:19
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
==========================================
+ Coverage 88.61% 88.65% +0.04%
==========================================
Files 165 165
Lines 13540 13540
==========================================
+ Hits 11998 12004 +6
+ Misses 1542 1536 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
Contributor
There absolutely is!! @marcduiker could you please help a friend here? 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
InvokeMethodRequest.http_verb = 'PATCH'raisedValueErrorbecause PATCH was missing from the request object's HTTP verb allowlist, even though the SDK's HTTP extension enum supports it. Add PATCH to that list.Add regression coverage for accepting PATCH, rejecting invalid verbs, and clearing a configured verb. This change concerns the request object's setter; public gRPC invocation already recognizes PATCH.
Issue reference
Closes #1350.
Validation
ruff check: passed.ruff format --check: 538 files already formatted.mypy: no issues in 230 source files.git diff --check: passed.Checklist
RELEASE NOTE: FIX Accept PATCH in InvokeMethodRequest HTTP verb validation.