Auto-Scale Scheduler#64
Open
cicoyle wants to merge 3 commits into
Open
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
artursouza
reviewed
Sep 16, 2024
artursouza
reviewed
Sep 16, 2024
artursouza
reviewed
Sep 16, 2024
artursouza
reviewed
Sep 16, 2024
artursouza
reviewed
Sep 16, 2024
artursouza
reviewed
Sep 16, 2024
artursouza
reviewed
Sep 16, 2024
artursouza
suggested changes
Sep 16, 2024
Contributor
artursouza
left a comment
There was a problem hiding this comment.
This is good. I have 2 concerns:
- We should not be in the business of auto-scaling etcd, we should fix the first 1 or 3 scheduler instances to run with etcd. The problem is mostly with scaling down. Even going from 3 to 5 there is not a lot of value IMO.
- This proposal is getting into a great deal of detail that makes me wonder: if this is not a breaking change, can we do it in 1.16?
…confusion Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Contributor
|
+1 binding |
1 similar comment
Member
|
+1 binding |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto scale scheduler proposal.
This design is based off a white boarding session done w/ @JoshVanL, thanks! 🚀