Add support for dead-letter topics in streaming subscriptions#1746
Open
siri-varma wants to merge 1 commit into
Open
Add support for dead-letter topics in streaming subscriptions#1746siri-varma wants to merge 1 commit into
siri-varma wants to merge 1 commit into
Conversation
siri-varma
changed the title
…1608) Adds optional deadLetterTopic parameter to the streaming subscribe APIs on DaprPreviewClient / DaprClientImpl, wiring it through to the SubscribeTopicEventsRequestInitialAlpha1.dead_letter_topic proto field. New overloads: - subscribeToEvents(pubsubName, topic, deadLetterTopic, listener, type) - subscribeToTopic(pubsubName, topic, deadLetterTopic, type) - subscribeToTopic(pubsubName, topic, deadLetterTopic, type, metadata) Existing methods delegate to the new ones with a null deadLetterTopic, and the field is only set on the request when a non-empty value is provided. Adds unit tests covering both presence and absence of the field on the gRPC initial frame. Fixes: dapr#1608 Signed-off-by: Siri Varma Vegiraju <s_vegiraju@apple.com>
siri-varma
force-pushed
the
users/svegiraju/add-dlq
branch
from
4e4dcc3 to
6313830
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1746 +/- ##
============================================
- Coverage 76.77% 76.76% -0.01%
- Complexity 2259 2264 +5
============================================
Files 241 241
Lines 7066 7072 +6
Branches 740 742 +2
============================================
+ Hits 5425 5429 +4
Misses 1277 1277
- Partials 364 366 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@javier-aliaga @dapr/maintainers-java-sdk Read for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional deadLetterTopic parameter to the streaming subscribe APIs on DaprPreviewClient / DaprClientImpl, wiring it through to the SubscribeTopicEventsRequestInitialAlpha1.dead_letter_topic proto field.
New overloads:
Existing methods delegate to the new ones with a null deadLetterTopic, and the field is only set on the request when a non-empty value is provided. Adds unit tests covering both presence and absence of the field on the gRPC initial frame.
Fixes: #1608
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: