add startedAt field to workflow metadata#99
Merged
Conversation
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
add-start-time-to-wf-metadata
branch
from
f735cb7 to
259f8c4
Compare
7 tasks
JoshVanL
requested changes
May 7, 2026
JoshVanL
left a comment
JoshVanL
left a comment
There was a problem hiding this comment.
Does this not need implementation changes?
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
JoshVanL
requested changes
May 7, 2026
cicoyle
requested changes
May 7, 2026
| LastUpdatedAt: resp.WorkflowState.LastUpdatedTimestamp, | ||
| FailureDetails: resp.WorkflowState.FailureDetails, | ||
| Version: resp.WorkflowState.Version, | ||
| StartedAt: resp.WorkflowState.ScheduledStartTimestamp, |
There was a problem hiding this comment.
Can you verify if we need to extend any tests in the repo?
There was a problem hiding this comment.
Pull request overview
This PR updates the Go protobuf surface to align with dapr/durabletask-protobuf#49 and exposes a new startedAt timestamp on workflow metadata as part of the generated backend-service protos.
Changes:
- Adds
startedAttodurabletask.protos.backend.v1.WorkflowMetadata(generated protobuf) and regenerates protos withprotoc-gen-go v1.33.0. - Updates the gRPC client metadata conversion to populate
WorkflowMetadata.StartedAt. - Pulls in additional regenerated proto changes (notably new
CreateDetachedWorkflowActionin orchestrator actions).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| client/client_grpc.go | Maps GetInstanceResponse.WorkflowState into backend.WorkflowMetadata, now including StartedAt. |
| api/protos/backend_service.pb.go | Generated proto update adding WorkflowMetadata.startedAt. |
| api/protos/orchestrator_actions.pb.go | Regenerated protos; includes new CreateDetachedWorkflowAction and updated oneofs/indexing. |
| api/protos/orchestrator_service.pb.go | Regenerated header/version updates. |
| api/protos/orchestration.pb.go | Regenerated header/version updates. |
| api/protos/runtime_state.pb.go | Regenerated header/version updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
add-start-time-to-wf-metadata
branch
from
ee7fa50 to
89bcf88
Compare
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
JoshVanL
requested changes
May 11, 2026
JoshVanL
left a comment
JoshVanL
left a comment
There was a problem hiding this comment.
@pablochacin need to update protobuf submodule ref?
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
famarting
approved these changes
May 13, 2026
JoshVanL
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using dapr/durabletask-protobuf#49