Skip to content

fix: use protojson camelcase default for wf payload serialization #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaron2 merged 1 commit into from
May 15, 2026
Merged

fix: use protojson camelcase default for wf payload serialization #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/orchestration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,9 @@ func WithRerunInput(input any) RerunOptions {
}
}

// protoMarshaler uses UseProtoNames so JSON output uses snake_case field names.
var protoMarshaler = protojson.MarshalOptions{UseProtoNames: true}
// protoMarshaler uses default protojson options so JSON output uses camelCase
// field names (the protojson default).
var protoMarshaler = protojson.MarshalOptions{}

// marshalData serializes v to JSON. Proto message types use protojson for
// correct handling of well-known types (e.g. google.protobuf.Struct);
Expand Down
6 changes: 3 additions & 3 deletions task/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,9 @@ func (te taskExecutor) Shutdown(ctx context.Context) error {
return nil
}

// protoMarshaler uses UseProtoNames so JSON output uses snake_case field names
// (matching the proto field names), which is the convention for workflow payloads.
var protoMarshaler = protojson.MarshalOptions{UseProtoNames: true}
// protoMarshaler uses default protojson options so JSON output uses camelCase
// field names (the protojson default).
var protoMarshaler = protojson.MarshalOptions{}

func unmarshalData(data []byte, v any) error {
if v == nil {
Expand Down
Loading