ci: update sdkdocs codeowners#5165
Open
mikeee wants to merge 1 commit into
Open
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5165.westus2.7.azurestaticapps.net |
Signed-off-by: Mike Nguyen <hey@mike.ee>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-coast-091fbe31e-5165.westus2.7.azurestaticapps.net |
Contributor
nelson-parente
left a comment
nelson-parente
left a comment
There was a problem hiding this comment.
Pre-review for @marcduiker handoff: LGTM. Adds SDK maintainer teams to CODEOWNERS for /sdkdocs/, enabling cross-SDK sanity checks without gating everything on docs maintainers. The @dapr/approvers-docs and @dapr/maintainers-docs teams remain as co-owners, so the two-approver requirement is preserved. Safe to merge after CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This adds all SDK maintainers as codeowners for docs. Given the recent-ish migration of SDK docs out of their respective repositories, there has been a removal of the SDK maintainers from the loop which is now gated by docs maintainers.
Following the discussion today about unblocking Docs progress - this was a result of the quick proposal. SDK maintainers are now able to approve docs for other SDKs whereby a sanity-check can be completed so at least two people are required to make changes to
/sdkdocs/.Following this PR, a change should be made to the permissions of the repository so that all maintainers have write access - gated by branch permissions/rulesets ensuring at least one other reviewer which should be in the CODEOWNERS.
Issue reference