docs(agents): document replay-aware logging for DurableAgent#5149
Open
Rishabh-git10 wants to merge 3 commits into
Open
docs(agents): document replay-aware logging for DurableAgent#5149Rishabh-git10 wants to merge 3 commits into
Rishabh-git10 wants to merge 3 commits into
Conversation
Signed-off-by: Rishabh Dewangan <107680241+Rishabh-git10@users.noreply.github.com>
4 tasks
Contributor
nelson-parente
left a comment
There was a problem hiding this comment.
Pre-review for @marcduiker handoff: LGTM with nits.
- The replay-aware logging subsection is a useful addition for DurableAgent users.
- The code example is Python and correctly uses
get_context_aware_loggerfromdapr_agents.utils. - Nit: double blank line before
## Core Agent Featuresheading (cosmetic). - Nit: the
@workflow_entrydecorator shown in the example isn't imported — consider adding the import or removing the decorator if it's just illustrative, to avoid reader confusion.
Nothing blocking — Marc, your call.
Signed-off-by: Rishabh Dewangan <107680241+Rishabh-git10@users.noreply.github.com>
Author
|
Thanks for the review @nelson-parente. I've addressed the nits just in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Added a "Replay-Aware Logging" subsection to the
DurableAgentcore concepts documentation. This details the usage of the newContextAwareLoggerutility, explaining how it hooks into theDaprWorkflowContextto seamlessly suppress duplicate log records during workflow state rehydration.Issue reference
Relates to implementation in dapr/dapr-agents#225