Repository navigation
feat: add Telegram and Zalo reminder scheduling - #20
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟡 Changes recommended
Missing-timezone handling conflicts with the promised default, and development can re-invoke completed reminders.
2 open findings
What changed in this PR
Adds chat-managed Telegram and Zalo reminders with secure routing, ownership isolation, and development scheduling.
Changes:
- Adds reminder authorization and direct delivery.
- Adds a process-local Croner development provider and tests.
- Documents reminder behavior and operational constraints.
| File | Description |
|---|---|
README.md |
Documents reminder usage and deployment behavior. |
package.json |
Adds Croner dependency. |
pnpm-lock.yaml |
Locks Croner 10.0.1. |
lib/reminders.ts |
Implements routing, authorization, and delivery. |
lib/reminders.test.ts |
Tests reminder security and delivery. |
lib/dev-schedules.ts |
Implements development scheduling. |
lib/dev-schedules.test.ts |
Tests timer lifecycle and failure handling. |
agent/schedules/reminders.ts |
Defines reminder schedule tools. |
agent/schedules/reminders.test.ts |
Tests approvals and owner isolation. |
agent/instructions.md |
Adds reminder-management guidance. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| throw new Error("Dev reminders do not support jitter; omit it from the schedule."); | ||
| } | ||
| const job = new Cron(expression.type === "single" ? expression.at : expression.cron, { | ||
| timezone: expression.timezone ?? "UTC", paused: true, unref: true, protect: true, |
| }); | ||
| }, | ||
| async invoke(ctx, name) { | ||
| await once(ctx, () => dispatch(requireEntry(ctx, name), `manual_${ctx.operationId}`, new Date().toISOString())); |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Intent
User asked how to allow Bubby bot to set schedules/reminders, then said Do it. Implement one-time and recurring text reminders for Telegram and Zalo, with list, reschedule, pause/resume and cancel, per-user ownership, trusted originating chat/topic routing, current allowlist checks at execution, and Asia/Ho_Chi_Minh as the default timezone. The user reported Zalo typing then silence; remove redundant tool approvals because Zalo has no approval UI and the chat request authorizes the bounded reminder action. The user reported a successful creation receipt but no delivery: the bundled Eve dev in-memory provider has no timers and parses UTC local date strings in the host timezone, so add a process-local timezone-aware dev scheduler. Dev reminders may be lost on restart/worker reload, failures pause reminders, jitter is unsupported in dev, while production must use Eve experimental Vercel Schedules with Vercel OIDC. Reminders send saved text directly rather than executing future agent tasks; provider retries may repeat delivery. User confirmed live Zalo and Telegram dev scheduling. User now explicitly asks to commit, push to main, deploy production, watch CI/Vercel, verify production health and production scheduling. Review and preserve these intended policies. Keep README focused on current setup, usage and essential operations; do not append change histories, test transcripts, deployment records or per-feature implementation notes. Existing production webhooks must be preserved. A feature branch is being used for validation before the authorized merge to main and production deployment.
What Changed
Risk Assessment
✅ Low: The change is bounded to reminder scheduling, preserves verified chat identity through creation and delivery, rechecks allowlists at execution, and its dev timer state transitions match the stated containment policy.
Testing
After resolving the initially absent lockfile dependencies, targeted tests exercised automatic timezone-aware firing, recurring pause/resume/reschedule/cancel behavior, failure pausing, ownership and allowlist checks, approval bypass, and direct Telegram/Zalo delivery. The manual provider transcript confirms saved text routes to the exact Telegram topic and Zalo chat; transient node_modules files were removed.
Evidence: Dev schedule delivery transcript (Telegram topic and Zalo chat)
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
pnpm install --frozen-lockfile(resolved missing local dependencies for the initial test attempt)node --test lib/reminders.test.ts lib/dev-schedules.test.ts agent/schedules/reminders.test.tsManual dev-provider delivery check: created and invoked one-time schedules for a Telegram topic and a Zalo private chat, recording the outbound saved-text routing in the evidence transcript.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.