fix(pulse): defer [da] identity to the user config (LIFEOS_CONFIG.toml)#1459
Open
anikin-xyz wants to merge 1 commit into
Open
fix(pulse): defer [da] identity to the user config (LIFEOS_CONFIG.toml)#1459anikin-xyz wants to merge 1 commit into
anikin-xyz wants to merge 1 commit into
Conversation
PULSE.toml ships a [da].primary value that could only be changed by editing the shipped system template — it was unoverridable from the user tier, so the DA name lived in two places (PULSE.toml and LIFEOS/USER/CONFIG/LIFEOS_CONFIG.toml [da].name) that could silently disagree. loadPulseConfig now defers [da].primary to LIFEOS_CONFIG.toml [da].name when present, via the existing LifeosConfig loader — converging the two identity configs on one source of truth rather than adding a third layer. Fresh installs without the user config keep the PULSE.toml value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PULSE's
[da].primarywas read only from the shippedPULSE.toml, so the DA name was unoverridable from the user tier — it lived in two files (PULSE.tomlandLIFEOS/USER/CONFIG/LIFEOS_CONFIG.toml [da].name) that could silently disagree.loadPulseConfignow defers[da].primarytoLIFEOS_CONFIG.toml [da].namewhen present, via the existingLifeosConfigloader — converging the two identity configs on one source of truth rather than adding a third layer. Fresh installs without the user config keep thePULSE.tomlvalue (try/catchfallback, functionally tested both ways).Composes cleanly with #1457 (which neutralizes the shipped placeholder): with both, the shipped value becomes a pure fresh-install fallback and the user config wins everywhere else.