fix(telegram): add explicit config switch for voice summaries#1458
Open
anikin-xyz wants to merge 1 commit into
Open
fix(telegram): add explicit config switch for voice summaries#1458anikin-xyz wants to merge 1 commit into
anikin-xyz wants to merge 1 commit into
Conversation
sendVoiceSummary was gated only by ELEVENLABS_API_KEY presence, so any install with the key set could not suppress Telegram voice notes without unsetting the key (which also disables the CLI /notify voice channel that shares it). Add a [telegram] voice_summaries flag, threaded through the existing loadPulseConfig → startTelegram → activeConfig path (no new plumbing). Defaults to enabled (undefined ⇒ on) so existing installs are unchanged; set voice_summaries = false to keep text replies but suppress voice notes. Health output reflects the switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendVoiceSummarywas gated only by the presence ofELEVENLABS_API_KEY. Because the Telegram module and the CLI/notifyVoiceServer share that one env var, an install that wants ElevenLabs for the CLI channel but not spoken Telegram notes had no way to turn the latter off short of unsetting the key (which kills both).This adds a
[telegram] voice_summariesflag, threaded through the existingloadPulseConfig → startTelegram → activeConfigpath — no new plumbing (loadPulseConfigalready passes the whole[telegram]table through). Defaults to enabled (undefined ⇒ on) so existing installs are unchanged; setvoice_summaries = falseto keep text replies but suppress the voice note.telegramHealth()reflects the switch.Design note: a dedicated
[telegram]flag was chosen over reusing the top-level[voice] enabledbecause[voice]gates the separate CLI VoiceServer//notifychannel — conflating the two surfaces would be wrong.