Potential fix for code scanning alert no. 3: Shell command built from environment values - #6
Merged
Merged
Conversation
… environment values Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
danielhaim1
marked this pull request as ready for review
August 19, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/danielhaim1/packr/security/code-scanning/3
Use
execFileSync(orspawnSyncwithshell: false) so the executable and arguments are passed separately and never parsed by a shell. This preserves behavior while removing command-injection/shell-metacharacter risk and also handles spaces in paths correctly.In
__tests__/test.js:child_processimport to includeexecFileSyncinstead ofexecSync.execSync(${packrBin} build --config ${configPath}, { ... })call withexecFileSync(packrBin, ['build', '--config', configPath], { ... }).stdioandenvoptions unchanged.This single change addresses all listed alert variants at the same sink location.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.