You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consume backend/model-owned request-generation parameter domains from Local LLM Server without inventing ranges or enabling configuration sweeps yet.
Boundary
/api/v1/models/registry enrichment remains first-party and best-effort.
GenerationParameterDomainReadModel validates the public producer shape and adds explicit scope=request_generation / source=local_llm_server while preserving provenance=registry_declared.
Domains stay model-scoped on DiscoveredModelReadModel and CandidateModelReadModel.
Runtime-load parameters remain separate and observational.
Malformed domain metadata is ignored with a warning; successful generic model discovery is preserved.
Deliberate VALUE-03A limit
This PR does not choose union/intersection semantics across models and does not expand a domain into configurations. bounded_generation_parameter_ranges remains empty and Quick/Standard/Thorough/Custom remain unavailable. Fixed remains the only executable strategy. Alias translation such as Korgis max_tokens -> Performance Lab max_output_tokens is deferred to VALUE-03B where it can be frozen into GenerationConfig, plan digest and Run fingerprints.
Tests
Focused contract tests cover:
valid Korgis numeric + boolean domains;
separation from runtime-load configuration;
malformed domain fail-closed behavior;
propagation into candidate planning while sweep strategies remain blocked.
Evidence boundary
Deterministic software semantics only. This makes no real-model/device/performance claim.
Integration gate
DO NOT MERGE while VALUE-02D #132 is not REAL_ENVIRONMENT PASS / VALUE-02 acceptance is not formally closed. Current dev already contains the VALUE-02 software integration, but #120 and #132 remain open; this PR does not reinterpret that as real acceptance.
Browser/Product/Built Product: selector N/A / skipped for this isolated contract slice
Producer daniele21/local-llm-server#205 is now merged to Local LLM Server dev (e7e186c96b66f4ddb3a01e926b5a43b69aceeca6).
The slice remains deliberately limited to declared-domain ingestion and model-scoped propagation. No configuration expansion/search strategy is enabled; bounded_generation_parameter_ranges remains empty and Fixed remains the only executable strategy.
Integration remains blocked: keep this PR draft / DO NOT MERGE until VALUE-02D #132 is REAL_ENVIRONMENT PASS and VALUE-02 acceptance is formally closed. This evidence is software semantics only and makes no real model/device/performance claim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent: #144
Producer contract: daniele21/korgis#205
Outcome
Consume backend/model-owned request-generation parameter domains from Local LLM Server without inventing ranges or enabling configuration sweeps yet.
Boundary
/api/v1/models/registryenrichment remains first-party and best-effort.GenerationParameterDomainReadModelvalidates the public producer shape and adds explicitscope=request_generation/source=local_llm_serverwhile preservingprovenance=registry_declared.DiscoveredModelReadModelandCandidateModelReadModel.Deliberate VALUE-03A limit
This PR does not choose union/intersection semantics across models and does not expand a domain into configurations.
bounded_generation_parameter_rangesremains empty and Quick/Standard/Thorough/Custom remain unavailable. Fixed remains the only executable strategy. Alias translation such as Korgismax_tokens-> Performance Labmax_output_tokensis deferred to VALUE-03B where it can be frozen intoGenerationConfig, plan digest and Run fingerprints.Tests
Focused contract tests cover:
Evidence boundary
Deterministic software semantics only. This makes no real-model/device/performance claim.
Integration gate
DO NOT MERGE while VALUE-02D #132 is not REAL_ENVIRONMENT PASS / VALUE-02 acceptance is not formally closed. Current
devalready contains the VALUE-02 software integration, but #120 and #132 remain open; this PR does not reinterpret that as real acceptance.