fix: align bundled health identity with product version - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Make the packaged macOS runtime expose the product bundle version in
/health, so target-Mac REAL_ENVIRONMENT server discovery validates the same application identity that the artifact manifest and Info.plist use.Root cause
The failed physical run on
dev@4746d8a83b01c9b2db67a463860e693cb52d5470reached a clean exact artifact and launched the packaged process, butreal_environment_smoke.pyreportedpackaged app loopback server not foundtwice. The discovery owner compares the bundle Info.plist version with/health.app_version.Those values came from different version owners:
VERSION/ Info.plist product version:0.2.0;local-asr-serverversion:0.1.0;get_app_version()exposed the Python package version even inside the frozen.app.A healthy packaged server was therefore eligible to be rejected as the wrong app identity.
Change
app_identity.py;CFBundleShortVersionString(fallbackCFBundleVersion) as application runtime version;0.2.0app does not expose the independent0.1.0Python package version.No capture, UI, persistence, network, cloud, or user-data behavior changes.
Axes
Follow-up
If deterministic validation passes, merge to
dev, refresh the exact candidate, then rerun LOCAL REAL_ENVIRONMENT once. The local wrapper must also collect the canonical evidence directory by the manifest/source revision rather than assuming a full-SHA directory name.