fix: keep native helper bundle generated-only - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Restore exact-source build cleanliness for LOCAL REAL_ENVIRONMENT and production packaging by treating the native capture helper
.appas generated output rather than tracked source.Root cause
build.shalready deletes and regeneratesbuild_assets/ClosedRoomNativeCapture.app, including a versionedInfo.plist. The tracked plist still contained an older product version, so an exact build rewrote tracked source.run_local_real_environment_suite.pycorrectly failed closed when it detected that dirty checkout; the same mutation could also violate production-build cleanliness.Change
build_assets/ClosedRoomNativeCapture.app/bundle;Info.plist;build.shstill regenerates and embeds the helper app.No runtime, capture, UX, privacy, or cloud behavior changes.
Axes
devcandidate.Evidence
The failed physical run on
dev@a47b4200…built a successful clean-manifest ad-hoc artifact but stopped before child physical checks because the build rewrote the tracked helperInfo.plist. This PR removes that source mutation rather than weakening the clean-checkout gate.