fix: bridge app-local keyboard shortcuts into WKWebView - #60
Merged
Merged
Conversation
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Route ClosedRoom's app-local keyboard events through the native AppKit window boundary before they enter WKWebView, preserving the existing frontend keydown behavior while making Cmd-K and Escape deterministic for the packaged macOS app.
Evidence / root cause
On exact candidate
23dafebbc4f2c00a0b92496fe73085387ef6ee1f, the repository-owned target-Mac diagnostic completed withshortcut_delivery_failed_search_ui_healthy:AXWebArea;AXTextField;This isolates the failure to synthetic AppKit -> WKWebView keyboard delivery rather than Search state, window activation, AX exposure, or the React Cmd-K listener.
Implementation
NSEventkey-down monitor owned byClosedRoomWindowManager;KeyboardEventinstances;key(pid, "cmd-k"), focus assertion,key(pid, "escape")).Product / privacy
Four axes
Release PR #49 remains blocked and must not be merged; any eventual integration changes the exact
devcandidate and invalidates prior exact-HEAD release evidence.