Skip to content

Lock version before changing its assets - #3024

Draft
jjnesbitt wants to merge 1 commit into
masterfrom
asset-change-version-lock
Draft

jjnesbitt wants to merge 1 commit into
masterfrom
asset-change-version-lock

Conversation

@jjnesbitt

Copy link
Copy Markdown
Member

Concurrent changes to the assets of one version could deadlock, as they lock the folders of the version's asset path tree and the version itself in conflicting orders. An asset update that changes the asset's path updates the version in between removing the old asset path and adding the new one, while every other change only updates the version after it has modified the asset paths.

This was observed in production, where assets were moved into a folder while other assets were being created in it.

Creating, updating and removing assets, as well as zarr ingestion, now lock the version before modifying any asset path, so that concurrent changes to a version are performed one at a time.

Concurrent changes to the assets of one version could deadlock, as they
lock the folders of the version's asset path tree and the version itself
in conflicting orders. An asset update that changes the asset's path
updates the version in between removing the old asset path and adding
the new one, while every other change only updates the version after it
has modified the asset paths.

This was observed in production, where assets were moved into a folder
while other assets were being created in it.

Creating, updating and removing assets, as well as zarr ingestion, now
lock the version before modifying any asset path, so that concurrent
changes to a version are performed one at a time.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@jjnesbitt
jjnesbitt force-pushed the asset-change-version-lock branch from c4635c1 to 36f770c Compare November 19, 2026 23:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant