Repository navigation
Conversation
Concurrent changes to the assets of one version could deadlock, as they lock the folders of the version's asset path tree and the version itself in conflicting orders. An asset update that changes the asset's path updates the version in between removing the old asset path and adding the new one, while every other change only updates the version after it has modified the asset paths. This was observed in production, where assets were moved into a folder while other assets were being created in it. Creating, updating and removing assets, as well as zarr ingestion, now lock the version before modifying any asset path, so that concurrent changes to a version are performed one at a time. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
jjnesbitt
force-pushed
the
asset-change-version-lock
branch
from
November 19, 2026 23:00
c4635c1 to
36f770c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent changes to the assets of one version could deadlock, as they lock the folders of the version's asset path tree and the version itself in conflicting orders. An asset update that changes the asset's path updates the version in between removing the old asset path and adding the new one, while every other change only updates the version after it has modified the asset paths.
This was observed in production, where assets were moved into a folder while other assets were being created in it.
Creating, updating and removing assets, as well as zarr ingestion, now lock the version before modifying any asset path, so that concurrent changes to a version are performed one at a time.